[update] rubocop 1.18.4 #4165

itowtips · 2021-10-05T00:44:08Z

No description provided.

…lid?.

…ng inject(:+) on an empty array.

…t explicitly instead of using block_given?.

… a variable that is used.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

rubocop

app/models/concerns/ss/addon/generate_lock.rb|30 col 131| Layout/LineLength: Line is too long. [184/130]
app/models/concerns/ss/model/user.rb|104 col 7| [Correctable] Style/CaseLikeIf: Convert if-elsif to case-when.
app/models/concerns/sys/ad.rb|16 col 30| [Correctable] Rails/ActiveRecordAliases: Use update instead of update_attributes.
app/models/gws/history.rb|106 col 131| Layout/LineLength: Line is too long. [146/130]
app/models/gws/monitor/topic.rb|35 col 3| [Correctable] Rails/ActiveRecordCallbacksOrder: after_validation is supposed to appear before around_destroy.
app/models/gws/monitor/topic.rb|138 col 7| [Correctable] Style/NegatedIfElseCondition: Invert the negated condition and swap the if-else branches.
app/models/sys/auth/open_id_connect/token_response.rb|4 col 131| [Correctable] Layout/LineLength: Line is too long. [161/130]
app/models/webmail/history.rb|108 col 131| Layout/LineLength: Line is too long. [133/130]
app/views/gws/presence/apis/users/index.json.jbuilder|8 col 31| [Correctable] Style/NestedParenthesizedCalls: Add parentheses to nested method call user_presence.label :state.
app/views/gws/presence/apis/users/show.json.jbuilder|8 col 31| [Correctable] Style/NestedParenthesizedCalls: Add parentheses to nested method call user_presence.label :state.
db/seeds/cms/contents/forms.rb|178 col 131| [Correctable] Layout/LineLength: Line is too long. [134/130]
db/seeds/cms/contents/forms.rb|179 col 131| [Correctable] Layout/LineLength: Line is too long. [141/130]
lib/tasks/ss/deploy.rake|8 col 7| Lint/DuplicateBranch: Duplicate branch body detected.
lib/tasks/voice/synthesis.rake|10 col 41| [Correctable] Style/IfWithBooleanLiteralBranches: Remove redundant ternary operator with boolean literal branches.
lib/translate/convertor.rb|13 col 31| [Correctable] Lint/UriRegexp: URI::regexp(%w(http https)) is obsolete and should not be used. Instead, use URI::DEFAULT_PARSER.make_regexp(%w(http https)).
spec/features/cms/agents/nodes/group_page_spec.rb|68 col 131| [Correctable] Layout/LineLength: Line is too long. [162/130]
spec/jobs/article/page/import_job_spec.rb|406 col 131| [Correctable] Layout/LineLength: Line is too long. [152/130]
spec/models/gws/system/menu_setting_spec.rb|154 col 7| Rails/I18nLocaleAssignment: Use I18n.with_locale with block instead of I18n.locale=.

github-actions · 2021-10-05T00:49:59Z

app/controllers/article/pages_controller.rb

- if !Article::Page::Importer.valid_encoding?(file.to_io, Encoding::SJIS)
- raise I18n.t("errors.messages.unsupported_encoding")
- end
+ if !Article::Page::Importer.valid_encoding?(file.to_io, Encoding::UTF_8) && !Article::Page::Importer.valid_encoding?(file.to_io, Encoding::SJIS)


[rubocop] _{reported by reviewdog 🐶}
[Correctable] Layout/LineLength: Line is too long. [150/130]

github-actions · 2021-10-05T00:49:59Z

app/controllers/cms/agents/nodes/archive_controller.rb

 render_url = "#{@cur_site.full_url}#{archive_path}"

 if preview_path?
- render_url = "#{cms_preview_path(site: @cur_site, path: @cur_main_path[1..-1].sub('/index.html', ''))}/#{Time.zone.now.strftime('%Y%m')}"
+ render_url = "#{cms_preview_path(site: @cur_site, path: @cur_main_path[1..].sub('/index.html', ''))}/#{Time.zone.now.strftime('%Y%m')}"


[rubocop] _{reported by reviewdog 🐶}
[Correctable] Layout/LineLength: Line is too long. [141/130]

github-actions · 2021-10-05T00:50:00Z

app/controllers/concerns/gws/presence/user_filter.rb

@@ -30,11 +30,11 @@ def set_manageable
 if Gws::UserPresence.allowed?(:manage_all, @cur_user, site: @cur_site)
 @manageable = true
 end
- if Gws::UserPresence.allowed?(:manage_private, @cur_user, site: @cur_site)
- @manageable = true if @group && (@group.id == @cur_user.gws_default_group.id)
+ if Gws::UserPresence.allowed?(:manage_private, @cur_user, site: @cur_site) && (@group && (@group.id == @cur_user.gws_default_group.id))


[rubocop] _{reported by reviewdog 🐶}
[Correctable] Layout/LineLength: Line is too long. [139/130]

github-actions · 2021-10-05T00:50:00Z

app/controllers/concerns/opendata/api/group_list_filter.rb

@@ -45,9 +45,9 @@ def group_list
 group_list << {id: group.id, state: group.state, name: group.name, order: group.order, packages: datasets.count}
 end

- if sort =~ /^name$/i
+ if /^name$/i.match?(sort)


[rubocop] _{reported by reviewdog 🐶}
[Correctable] Style/CaseLikeIf: Convert if-elsif to case-when.

github-actions · 2021-10-05T00:50:00Z

app/controllers/concerns/opendata/api/resource_search_filter.rb

@@ -31,13 +31,13 @@ def resource_search_check(queries, order_by, offset, limit)
 end

 def convert_property_name(field)
- if field =~ /^name$/i
+ if /^name$/i.match?(field)


[rubocop] _{reported by reviewdog 🐶}
[Correctable] Style/CaseLikeIf: Convert if-elsif to case-when.

github-actions · 2021-10-05T00:50:03Z

app/models/cms/column/value/url_field2.rb

- if link_label.length > column.label_max_length
- self.errors.add(:link_label, :too_long, count: column.label_max_length)
- end
+ if link_label.present? && column.label_max_length.present? && column.label_max_length > 0 && (link_label.length > column.label_max_length)


[rubocop] _{reported by reviewdog 🐶}
Layout/LineLength: Line is too long. [142/130]

github-actions · 2021-10-05T00:50:04Z

app/models/cms/column/value/url_field2.rb

- if link_url.length > column.link_max_length
- self.errors.add(:link_url, :too_long, count: column.link_max_length)
- end
+ if link_url.present? && column.link_max_length.present? && column.link_max_length > 0 && (link_url.length > column.link_max_length)


[rubocop] _{reported by reviewdog 🐶}
Layout/LineLength: Line is too long. [135/130]

github-actions · 2021-10-05T00:50:04Z

app/models/concerns/gws/memo/notice_user_setting.rb

+ when "gws/faq/topic", "gws/faq/post" then 'faq'
+ when "gws/qna/topic", "gws/qna/post" then 'qna'
+ when "gws/schedule/todo" then 'todo'
+ when "gws/schedule/todo_comment" then 'todo'


⚠️ [rubocop] _{reported by reviewdog 🐶}
Lint/DuplicateBranch: Duplicate branch body detected.

github-actions · 2021-10-05T00:50:04Z

app/models/concerns/gws/model/folder.rb

- if dependant_scope.where(name: self.name).present? && dependant_scope.where(id: self.id).first.name != self.name
- errors.add :base, :not_move_to_same_name_folder
- end
+ if self.id != 0 && (dependant_scope.where(name: self.name).present? && dependant_scope.where(id: self.id).first.name != self.name)


[rubocop] _{reported by reviewdog 🐶}
Layout/LineLength: Line is too long. [134/130]

github-actions · 2021-10-05T00:50:04Z

app/models/concerns/jmaxml/helper/forecast.rb

@@ -14,11 +14,11 @@ def each_areas(&block)
 kind_code = kind.elements['Code'].text.to_s.strip
 kind_status = kind.elements['Status'].text.to_s.strip

- if kind_name =~ /特別警報/
+ if /特別警報/.match?(kind_name)


[rubocop] _{reported by reviewdog 🐶}
[Correctable] Style/CaseLikeIf: Convert if-elsif to case-when.

github-actions · 2021-10-05T00:50:11Z

app/models/concerns/ss/addon/generate_lock.rb

- if generate_lock_until > Time.zone.now + SS::Duration.parse(SS.config.cms.generate_lock['generate_lock_until'])
- errors.add :generate_lock_until, :disallow_datetime_by_system
- end
+ if SS.config.cms.generate_lock['generate_lock_until'].present? && (generate_lock_until > Time.zone.now + SS::Duration.parse(SS.config.cms.generate_lock['generate_lock_until']))


[rubocop] _{reported by reviewdog 🐶}
Layout/LineLength: Line is too long. [184/130]

github-actions · 2021-10-05T00:50:11Z

app/models/concerns/ss/model/user.rb

@@ -101,9 +101,9 @@ module SS::Model::User

 module ClassMethods
 def flex_find(keyword)
- if keyword =~ /^\d+$/
+ if /^\d+$/.match?(keyword)


[rubocop] _{reported by reviewdog 🐶}
[Correctable] Style/CaseLikeIf: Convert if-elsif to case-when.

github-actions · 2021-10-05T00:50:12Z

app/models/concerns/sys/ad.rb

@@ -13,6 +13,6 @@ module Sys::Ad
 private

 def file_state_update
- files.each {|file| file.update_attributes(state: "public")}
+ files.each { |file| file.update_attributes(state: "public") }


⚠️ [rubocop] _{reported by reviewdog 🐶}
[Correctable] Rails/ActiveRecordAliases: Use update instead of update_attributes.

github-actions · 2021-10-05T00:50:12Z

app/models/gws/history.rb

- if severity_to_num(severity) >= severity_to_num(allowed_severity)
- item.save!(context: context.to_sym)
- end
+ if allowed_severity = cur_site.allowed_log_severity_for(item.module_key) && (severity_to_num(severity) >= severity_to_num(allowed_severity))


[rubocop] _{reported by reviewdog 🐶}
Layout/LineLength: Line is too long. [146/130]

github-actions · 2021-10-05T00:50:12Z

app/models/gws/monitor/topic.rb

+ around_destroy ::Gws::Elasticsearch::Indexer::MonitorTopicJob.callback
+
+ #validates :category_ids, presence: true
+ after_validation :set_descendants_updated_with_released, if: -> { released.present? && released_changed? }


[rubocop] _{reported by reviewdog 🐶}
[Correctable] Rails/ActiveRecordCallbacksOrder: after_validation is supposed to appear before around_destroy.

github-actions · 2021-10-05T00:50:14Z

lib/tasks/voice/synthesis.rake

@@ -7,7 +7,7 @@ namespace :voice do
 task synthesis: [:environment, :setup_logger] do
 id_or_url = ENV["id"] || ENV["url"]
 force = ENV["force"] || "false"
- force = force =~ /^(false|0)$/i ? false : true
+ force = /^(false|0)$/i.match?(force) ? false : true


[rubocop] _{reported by reviewdog 🐶}
[Correctable] Style/IfWithBooleanLiteralBranches: Remove redundant ternary operator with boolean literal branches.

github-actions · 2021-10-05T00:50:14Z

lib/translate/convertor.rb

- return false if text =~ /\A#{URI::regexp(%w(http https))}\z/
- return false if text =~ /\A[#{I18n.t("translate.ignore_character")}]+\z/
+ return false if EmailValidator::REGEXP.match?(text)
+ return false if /\A#{URI::regexp(%w(http https))}\z/.match?(text)


⚠️ [rubocop] _{reported by reviewdog 🐶}
[Correctable] Lint/UriRegexp: URI::regexp(%w(http https)) is obsolete and should not be used. Instead, use URI::DEFAULT_PARSER.make_regexp(%w(http https)).

github-actions · 2021-10-05T00:50:14Z

spec/features/cms/agents/nodes/group_page_spec.rb

- let! (:child_loop_html) { '<li><a href="#{url}">#{index_name}</a></li>' }
- let! (:child_lower_html) { '</ul>' }
+ let!(:upper_html) { '<div class="middle dw">' }
+ let!(:loop_html) { '<section class="item dw-panel"><div class="dw-panel__content"><h2><a href="#{url}">#{index_name}</a></h2>#{child_items}</div></section>' }


[rubocop] _{reported by reviewdog 🐶}
[Correctable] Layout/LineLength: Line is too long. [162/130]

github-actions · 2021-10-05T00:50:14Z

spec/jobs/article/page/import_job_spec.rb

- expect(page3.category_ids).to match_array [cate2_3.id]
- expect(page4.category_ids).to match_array [cate2_2.id, cate1_4.id]
+ expect(page1.category_ids).to match_array [cate1_depth3.id, cate2_depth3.id]
+ expect(page2.category_ids).to match_array [cate1_depth3.id, cate2_depth3.id, cate1_depth2.id, cate2_depth2.id, cate1_depth1.id, cate2_depth1.id]


[rubocop] _{reported by reviewdog 🐶}
[Correctable] Layout/LineLength: Line is too long. [152/130]

github-actions · 2021-10-05T00:50:14Z

spec/models/gws/system/menu_setting_spec.rb

@@ -151,7 +151,7 @@

 it do
 I18n.enforce_available_locales = false
- I18n.locale = 'zh-TW'.to_sym
+ I18n.locale = :'zh-TW'


[rubocop] _{reported by reviewdog 🐶}
Rails/I18nLocaleAssignment: Use I18n.with_locale with block instead of I18n.locale=.

This reverts commit 0fdbba6.

github-actions · 2021-10-05T01:27:17Z

app/models/concerns/rdf/object.rb

@@ -74,7 +74,7 @@ def normalize_name
 def validate_name
 return if name.blank?
 # symbols is not allowed.
- errors.add :name, :invalid if name =~ /[\x00-,:-@\[-\^`\{-\x7f]/
+ errors.add :name, :invalid if name =~ /[\x00-,:-@\[-\^`{-\x7f]/


[rubocop] _{reported by reviewdog 🐶}
[Correctable] Performance/RegexpMatch: Use match? instead of =~ when MatchData is not used.

github-actions · 2021-10-05T01:27:17Z

app/models/opendata/graph/base.rb

@@ -67,9 +60,9 @@ def extract_datasets

 def format_data(data)
 return "-" if data.blank?
- return data if data !~ /^(\-)?((\d)+\,)?((\d)+\.)?+(\d)+$/
+ return data if data !~ /^(-)?((\d)+,)?((\d)+\.)?+(\d)+$/


[rubocop] _{reported by reviewdog 🐶}
[Correctable] Performance/RegexpMatch: Use match? instead of !~ when MatchData is not used.

github-actions · 2021-10-05T01:27:17Z

lib/mobile/converter.rb

@@ -85,12 +85,12 @@ def gsub_img!
 name = src_attr["alt"].presence || src_attr["title"].presence || href.sub(/.*\//, "")
 cls = "tag-img" + ( src_attr["class"] ? " #{src_attr['class']}" : "" )

- if href =~ /^\/fs\/.+?\/\_\/.+?#{ext}/
+ if href =~ /^\/fs\/.+?\/_\/.+?#{ext}/


[rubocop] _{reported by reviewdog 🐶}
[Correctable] Performance/RegexpMatch: Use match? instead of =~ when MatchData is not used.

This reverts commit 5c96415.

This reverts commit c1801c5.

github-actions · 2021-10-05T02:29:36Z

app/controllers/board/agents/nodes/post_controller.rb

@@ -58,7 +58,7 @@ def index
 def create
 @item = @model.new get_params
 if @cur_node.captcha_enabled? && get_captcha[:captcha_error].nil?
- unless is_captcha_valid?(@item)
+ unless captcha_valid?(@item)


[rubocop] _{reported by reviewdog 🐶}
[Correctable] Style/SoleNestedConditional: Consider merging nested conditions into outer if conditions.

github-actions · 2021-10-05T02:29:36Z

app/controllers/board/agents/nodes/post_controller.rb

@@ -75,7 +75,7 @@ def new_reply
 def reply
 @item = @model.new get_params
 if @cur_node.captcha_enabled? && get_captcha[:captcha_error].nil?
- unless is_captcha_valid?(@item)
+ unless captcha_valid?(@item)


[rubocop] _{reported by reviewdog 🐶}
[Correctable] Style/SoleNestedConditional: Consider merging nested conditions into outer if conditions.

github-actions · 2021-10-05T02:29:36Z

app/controllers/inquiry/agents/nodes/form_controller.rb

@@ -119,7 +119,7 @@ def create
 end

 if @cur_node.captcha_enabled? && get_captcha[:captcha_error].nil?
- unless is_captcha_valid?(@answer)
+ unless captcha_valid?(@answer)


[rubocop] _{reported by reviewdog 🐶}
[Correctable] Style/SoleNestedConditional: Consider merging nested conditions into outer if conditions.

coveralls · 2021-10-05T03:02:57Z

Coverage decreased (-0.04%) to 84.576% when pulling d174027 on fix-rubocop-issues into 617308b on master.

sunny4381 · 2021-10-21T08:56:49Z

@itowtips
Rails::ReflectionClassName が app/models/concerns/ss/relation/file.rb や app/models/concerns/workflow/addon/branch.rb で false positive になりますが、
Rubocop をバージョンアップしても、改善されていないなら Rails::ReflectionClassName を無効にして欲しいです。

参考: rubocop/rubocop-rails#106

itowtips · 2021-11-04T11:39:43Z

リベース #4227

itowtips added 30 commits October 5, 2021 09:31

[update] rubocop 1.18.4

d2f1d50

Rails/HelperInstanceVariable: false

1b1f086

Style/StringConcatenation: false

6e5fda2

Layout/ArgumentAlignment: false

840f36a

Rails/NegateInclude: false

703f6e9

Style/RedundantBegin: false

afee7f3

Style/HashEachMethods: false

24c4c6a

Style/HashAsLastArrayItem: false

a7c1513

[modify] Naming/MethodParameterName

4be23ec

[modify] Naming/VariableNumber

cca2cb9

[modify] Naming/UncommunicativeMethodParamName

dae1cd3

[modify] Naming/PredicateName: Rename is_captcha_valid? to captcha_va…

073795d

…lid?.

[modify] Style/ClassEqualityComparison

7882ffc

[modify] Performance/StringReplacement: Use tr instead of gsub.

3ea2a95

[modify] Performance/Sum: Use sum { ... } instead of map { ... }.sum.

6b27c1b

[modify] Performance/Sum: Use sum instead of inject(:+), unless calli…

a7c6d56

…ng inject(:+) on an empty array.

[modify] Style/StringChars

8c7178f

[modify] Source code comment is empty.

629d993

[modify] Style/QuotedSymbols

e206f64

[modify] Style/MultilineWhenThen

77736fc

[modify] Style/SlicingWithRange: Prefer ary[n..] over ary[n..-1].

4376ec1

[modify] Performance/BlockGivenWithExplicitBlock: Check block argumen…

28adb2a

…t explicitly instead of using block_given?.

[modify] Style/TrailingCommaInHashLiteral

f989d66

[modify] Style/SoleNestedConditional

5c96415

[modify] Style/AccessorGrouping

719579b

[modify] Style/MethodCallWithoutArgsParentheses

ebab049

[modify] Layout/EmptyLinesAroundAttributeAccessor

213bff5

[modify] Layout/ExtraSpacing

a8d05f8

[modify] Layout/ArrayAlignment

3b8f60f

[modify] Performance/RegexpMatch

0fdbba6

itowtips added 12 commits October 5, 2021 09:37

[modify] Lint/UselessAccessModifier

8841e77

[modify] Layout/EndAlignment

e77927d

[modify] Style/RedundantArgument

15205d4

[modify] Performance/StringReplacement: Use tr instead of gsub.

fb0c9a7

[modify] Performance/Detect

c1801c5

[modify] Layout/SpaceInsideBlockBraces

e3d512f

[modify] Lint/ParenthesesAsGroupedExpression

fecd49f

[modify] Redundant escape inside regexp literal

fae6928

[modify] Style/HashConversion

c903cda

[modify] Lint/UnderscorePrefixedVariableName: Do not use prefix _ for…

b11d23b

… a variable that is used.

[modify] Style/ExplicitBlockArgument

9d81cc9

[modify] .rubocop_todo.yml

ca3e28b

github-actions bot reviewed Oct 5, 2021

View reviewed changes

Revert "[modify] Performance/RegexpMatch"

a71887b

This reverts commit 0fdbba6.

github-actions bot reviewed Oct 5, 2021

View reviewed changes

itowtips added 2 commits October 5, 2021 11:12

Revert "[modify] Style/SoleNestedConditional"

f26431e

This reverts commit 5c96415.

Revert "[modify] Performance/Detect"

d174027

This reverts commit c1801c5.

github-actions bot reviewed Oct 5, 2021

View reviewed changes

itowtips closed this Nov 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[update] rubocop 1.18.4 #4165

[update] rubocop 1.18.4 #4165

itowtips commented Oct 5, 2021

github-actions bot left a comment

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

github-actions bot Oct 5, 2021

coveralls commented Oct 5, 2021 •

edited

Loading

sunny4381 commented Oct 21, 2021

itowtips commented Nov 4, 2021 •

edited

Loading

[update] rubocop 1.18.4 #4165

[update] rubocop 1.18.4 #4165

Conversation

itowtips commented Oct 5, 2021

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

github-actions bot Oct 5, 2021

Choose a reason for hiding this comment

coveralls commented Oct 5, 2021 • edited Loading

sunny4381 commented Oct 21, 2021

itowtips commented Nov 4, 2021 • edited Loading

coveralls commented Oct 5, 2021 •

edited

Loading

itowtips commented Nov 4, 2021 •

edited

Loading