[process][windows] Retrieve process name as basename of executable #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… more idiomatic Go
We align ourself with psutil https://github.com/giampaolo/psutil/blob/8e4099d9f063ceb4ee3da5845562c5b934f83544/psutil/_pswindows.py#L749-L759 Benchmarks show vast improvements go test -run=BenchmarkProcessName -bench=BenchmarkProcessName ./process goos: windows goarch: amd64 pkg: github.com/shirou/gopsutil/v3/process cpu: Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz BenchmarkProcessName-4 180 6564033 ns/op BenchmarkProcessNameViaExe-4 22111 51153 ns/op PASS ok github.com/shirou/gopsutil/v3/process 3.914s Fixes shirou#1368
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We align ourself with psutil
https://github.com/giampaolo/psutil/blob/8e4099d9f063ceb4ee3da5845562c5b934f83544/psutil/_pswindows.py#L749-L759
Benchmarks show vast improvements
Fixes #1368