Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncate the Getfsstat result to the count of items that were returned #1392

Merged
merged 4 commits into from
Dec 18, 2022
Merged

Truncate the Getfsstat result to the count of items that were returned #1392

merged 4 commits into from
Dec 18, 2022

Conversation

brianryner8
Copy link
Contributor

This count may be less than what was returned by the first call to Getfsstat.

Fixes #1390

@brianryner8
Truncate the result of Getfsstat to the item count that is returned.
c5e42b9 
This count may be less than what was returned by the first call to Getfsstat.
@brianryner8
fix
34da06e
@brianryner8 brianryner8 marked this pull request as ready for review December 7, 2022 03:35
@brianryner8
Copy link
Contributor Author

Note, I think the freebsd and openbsd implementations are similarly affected, but I don't have an environment to test changes there.

@brianryner8
Copy link
Contributor Author

@shirou would you be able to review this please?

I'm also wondering if you'd accept the fix on the v2 branch? Or are no more releases planned there?

Thanks,

@shirou
Copy link
Owner

shirou commented Dec 12, 2022

  • I have quite limited time, and that only on weekends. (Last weekend, I ran out of budgets in the middle of review.)
  • v2 branch is not maintained and no more release(except security issue).

@brianryner8 brianryner8 mentioned this pull request Dec 17, 2022
Closed
@brianryner8
Copy link
Contributor Author

Updated the comment to mention 10.14 specifically, but also include the possibility that it affects other past or future releases.

shirou
shirou approved these changes Dec 18, 2022
View reviewed changes
Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your updates and great contribution!

@shirou shirou merged commit 39f3b34 into shirou:master Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirou shirou shirou approved these changes

Assignees
No one assigned
Labels
package:disk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Partitions() on macOS may return uninitialized elements
2 participants
@brianryner8 @shirou