Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get tests passing on s390x #1414

Merged
merged 1 commit into from
Feb 12, 2023

Conversation

jeffweiss
Copy link

This should address the test errors reported in #990

Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a s390x so I can not confirm it works or not. However this PR seems does not break compatibility on other platform. So I merge this. Thank you for your great contribution!

@Nayana-ibm
Copy link

@shirou I can verify on s390x. Please let me know the steps to build/test.

@Nayana-ibm
Copy link

I verified using steps mentioned in Github Actions build_test
All tests passing on s390x.

go: downloading github.com/tklauser/go-sysconf v0.3.11
go: downloading github.com/stretchr/testify v1.8.4
go: downloading golang.org/x/sys v0.9.0
go: downloading github.com/tklauser/numcpus v0.6.0
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading gopkg.in/yaml.v3 v3.0.1
?       github.com/shirou/gopsutil/v3   [no test files]
?       github.com/shirou/gopsutil/v3/common    [no test files]
ok      github.com/shirou/gopsutil/v3/cpu       0.202s
ok      github.com/shirou/gopsutil/v3/disk      0.020s
ok      github.com/shirou/gopsutil/v3/docker    0.164s
ok      github.com/shirou/gopsutil/v3/host      0.023s
ok      github.com/shirou/gopsutil/v3/internal/common   0.064s
ok      github.com/shirou/gopsutil/v3/load      0.022s
ok      github.com/shirou/gopsutil/v3/mem       0.009s
ok      github.com/shirou/gopsutil/v3/net       0.017s
ok      github.com/shirou/gopsutil/v3/process   2.266s

@Nayana-ibm Nayana-ibm mentioned this pull request Jun 30, 2023
@jeffweiss jeffweiss deleted the bugfix/get_tests_working_on_s390x branch June 30, 2023 19:55
@shirou
Copy link
Owner

shirou commented Jul 1, 2023

Great! Thank you for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants