-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual available memory calculation #626
Merged
shirou
merged 6 commits into
shirou:master
from
mznet:manual-available-memory-calculation
Mar 1, 2019
Merged
Manual available memory calculation #626
shirou
merged 6 commits into
shirou:master
from
mznet:manual-available-memory-calculation
Mar 1, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is needed to calcuate manually manual available memory calculation should be done if only memavail is false Manual Available Memory calculation under kernel 3.14 accurate manaul available memory calculation
mznet
force-pushed
the
manual-available-memory-calculation
branch
from
January 6, 2019 14:22
b9a6bc5
to
73545ec
Compare
shirou
reviewed
Jan 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, it is good point! I commented some small things. I will merge if you update.
1 task
Lomanic
reviewed
Feb 8, 2019
@Lomanic Thank you for reviewing. I think this is good to merge now. How do you think? |
Merged it. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At kernel 3.14
MemAvailable
metric was introduced, but under 3.14,MemAvailable
didn't exist and needed to calculate manully to get, gopsutil have estimated it summing free, cached, and buffer metric. Summing metrics was good idea, could be approached toMemAvailable
nearly, not perfectly. Calculating the metric more precisely, I am referring topsutil
and kernel algorithm.psutil
giampaolo/psutil@8504d93
kernel
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=34e431b0ae398fc54ea69ff85ec700722c9da773