Feature/remove disk partition args on bsds #975
Conversation
According to giampaolo/psutil#906, all BSD system returns same information `df` and `df -a`.
shirou
force-pushed
the
feature/remove_disk_partition_args_on_bsds
branch
3 times, most recently
from
caefcbb to
5600b03
Compare
shirou
force-pushed
the
feature/remove_disk_partition_args_on_bsds
branch
from
5600b03 to
23a5246
Compare
There was a problem hiding this comment.
Adding the Pull request labeler action is a good idea. I would add - **/*_bsd.go for os:freebsd and os:openbsd automatic tagging to not miss these files:
find -name '*_bsd*.go' -exec grep "^// +build" {} +
./load/load_bsd.go:// +build freebsd openbsd
./process/process_bsd.go:// +build darwin freebsd openbsd
./host/host_bsd.go:// +build darwin freebsd openbsd
| @@ -14,6 +13,8 @@ func Partitions(all bool) ([]PartitionStat, error) { | |||
| return PartitionsWithContext(context.Background(), all) | |||
| } | |||
|
|
|||
| // PartitionsWithContext returns disk partition. | |||
There was a problem hiding this comment.
I would prefer to have the same documentation centralized for all OSes (like in psutil for example), as godoc.org only displays documentation for linux/amd64. So this should be moved to disk/disk_linux.go (saying "all argument is ignored on darwin, freebsd and openbsd, see: giampaolo/psutil#906"). This documentation will be moved to disk/disk.go once Partitions() definition is moved there (#761).
There was a problem hiding this comment.
Yes, agree. sorry, that comment is a my tentative note and forget to remove. I will open another PR which aligns to #761. At that PR, I will move comment to disk_linux.go
|
Thank you for the comment! I will add |
I found psutil ignore argument on BSD systems according to the issue.
This PR changes to return all partition information.
(These code is written in 2016 and I can not remember why add path evaluation)