fix(react): refactoring hasKeySchema computation (datahub-project#3146)

shirshanka · Aug 27, 2021 · 6319228 · 6319228
1 parent 70c92db
commit 6319228
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/datahub-web-react/src/app/entity/dataset/profile/schema/Schema.tsx b/datahub-web-react/src/app/entity/dataset/profile/schema/Schema.tsx
@@ -63,10 +63,14 @@ export default function SchemaView({
         fetchPolicy: 'no-cache',
     });
 
-    const hasKeySchema = useMemo(
-        () => (schema?.fields?.findIndex((field) => field.fieldPath.indexOf(KEY_SCHEMA_PREFIX) > -1) || -1) !== -1,
-        [schema],
-    );
+    const hasKeySchema = useMemo(() => {
+        const keySchemaIndex = schema?.fields?.findIndex((field) => field.fieldPath.indexOf(KEY_SCHEMA_PREFIX) > -1);
+        if (keySchemaIndex !== undefined && keySchemaIndex > -1) {
+            // We found a key schema.
+            return true;
+        }
+        return false;
+    }, [schema]);
 
     const [showKeySchema, setShowKeySchema] = useState(false);