Skip to content

Latest commit

 

History

History
31 lines (24 loc) · 1.14 KB

Expected behavior regarding authorization for adding tokens is unclear.md

File metadata and controls

31 lines (24 loc) · 1.14 KB

addToken allows anyone to list a new token on Hermez.

This contradicts the online documentation, which implies that only the governance should have this authorization.

It is unclear whether the implementation or the documentation is correct.

Recommendation:

Short term, update either the implementation or the documentation to standardize the authorization specification for adding tokens.

Long term, write a specification of each function and thoroughly test it with unit tests and fuzzing.

Use symbolic execution for arithmetic invariants.


Slide Screenshot

155.jpg


Slide Text

  • ToB Audit Hermez Network Finding 21
  • Access Control
  • Adding New tokens
  • Anyone or Governance
  • Sync Specification -> Implementation

References


Tags