Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tombstone support #900

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Tombstone support #900

wants to merge 1 commit into from

Conversation

shish
Copy link
Owner

@shish shish commented Feb 4, 2023

When an image is deleted, add a database entry; if somebody tries to view that image, show the tombstone instead of the default 404 page

@AstroAntics
Copy link

AstroAntics commented Apr 12, 2023

Did you get the idea from Newgrounds? I remember they had a tombstone there too. I don't remember if it had a reason or not to go along with it. Do you think there's any benefit to showing the user why the image was deleted?

I personally believe that there would be (i.e. "banned hash", "poor quality", "TOS", etc), but I can see the flip-side of the argument as well. Some other sites already do this anyway, and display why an image was deleted if you go over it.

edit: Since the "tombstone" itself is a database entry, the comment could be stored in a varchar/smalltext column in case the site needs to bring it up.

@shish
Copy link
Owner Author

shish commented Apr 12, 2023

I got the idea from end-user requests, no idea where they got it from - there are pros and cons, but if it's an option that site owners can choose to enable or disable for their own sites then it seems sensible to add it :3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants