Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added configuration #3

Merged
merged 2 commits into from
Oct 4, 2022
Merged

added configuration #3

merged 2 commits into from
Oct 4, 2022

Conversation

jorqensen
Copy link
Contributor

wip

@RTippin
Copy link

RTippin commented Oct 3, 2022

Very reasonable. LGTM ✅️

@jorqensen jorqensen requested a review from arkoe October 3, 2022 21:15
@jorqensen jorqensen added the enhancement New feature or request label Oct 3, 2022
@jorqensen
Copy link
Contributor Author

@arkoe anything missing?

@jorqensen jorqensen marked this pull request as ready for review October 3, 2022 21:16
arkoe
arkoe reviewed Oct 4, 2022
View reviewed changes
src/resources/views/trongate.blade.php Outdated Show resolved Hide resolved
src/config/trongate.php Outdated Show resolved Hide resolved
src/config/trongate.php Outdated Show resolved Hide resolved
arkoe
arkoe approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@arkoe arkoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@arkoe arkoe merged commit c71ded2 into main Oct 4, 2022
@arkoe arkoe deleted the feat-configurable-redirect-time branch October 4, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkoe arkoe arkoe approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorqensen @RTippin @arkoe