Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony workflow enhancement #376

Closed
smoqadam opened this issue Dec 19, 2020 · 2 comments · Fixed by #377
Closed

Symfony workflow enhancement #376

smoqadam opened this issue Dec 19, 2020 · 2 comments · Fixed by #377

Comments

@smoqadam
Copy link
Contributor

Hi and thanks for this action.

The first time when you run php bin/phpunit it tries to install phpunit dependencies which it messes the tests log.

image

to avoid that, we should add php bin/phpunit install command to Install Composer Dependencies step to install dependencies first then run the tests.
@shivammathur
Copy link
Owner

@smoqadam Will you be willing to submit a PR to improve this.

smoqadam added a commit to smoqadam/setup-php that referenced this issue Dec 19, 2020
@smoqadam
issue shivammathur#376 - Install phpunit dependencies before runs the…
81964ae 
… tests
@smoqadam smoqadam mentioned this issue Dec 19, 2020
Merged
shivammathur added a commit that referenced this issue Dec 19, 2020
@shivammathur
Merge pull request #377 from smoqadam/master
862f206 
issue #376 - Install phpunit dependencies before runs the tests
@shivammathur shivammathur linked a pull request Dec 19, 2020 that will close this issue
issue #376 - Install phpunit dependencies before runs the tests #377
Merged
@shivammathur
Copy link
Owner

Fixed in #377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

issue #376 - Install phpunit dependencies before runs the tests smoqadam/setup-php
2 participants
@smoqadam @shivammathur