Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed small typo in README.md #889

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

alexmerlin
Copy link
Contributor


name: 🐞 Bug Fix
about: There is a small typo in README.md instructing devs to use a GHA with invalid code - this PR fixes it
labels: bug


A Pull Request should be associated with a Discussion.

If you're fixing a bug, adding a new feature or improving something please provide the details in discussions,
so that the development can be pointed in the intended direction.

Related discussion:

Further notes in Contribution Guidelines
Thank you for your contribution.

Description

In README.md, under the Matrix Setup section there is a line with the following invalid code:

php-versions: [8.2', '8.3', '8.4']

This PR adds the missing single quote:

php-versions: ['8.2', '8.3', '8.4']

In case this PR introduced TypeScript/JavaScript code changes:

  • I have written test cases for the changes in this pull request
  • I have run npm run format before the commit.
  • I have run npm run lint before the commit.
  • I have run npm run release before the commit.
  • npm test returns with no unit test errors and all code covered.

In case this PR edits any scripts:

  • I have checked the edited scripts for syntax.
  • I have tested the changes in an integration test (If yes, provide workflow YAML and link).

Signed-off-by: alexmerlin <alex@dotkernel.com>
@shivammathur shivammathur merged commit e7453ef into shivammathur:develop Dec 2, 2024
@shivammathur
Copy link
Owner

@alexmerlin Thanks!

@alexmerlin alexmerlin deleted the fix-readme-typo branch December 2, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants