Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a service container #38

Merged
merged 1 commit into from
May 12, 2024
Merged

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented May 12, 2024

Closes #37

Add initial implementation of a dependency injection container for the server, using bottlejs.

Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 59.25926% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 61.28%. Comparing base (12e39d2) to head (8d4071e).
Report is 1 commits behind head on main.

Files Patch % Lines
app/api/apiClientBuilder.server.ts 45.00% 11 Missing ⚠️
app/routes/server.$serverId.shlink-api.$method.ts 0.00% 5 Missing ⚠️
app/routes/server.$serverId.$.tsx 0.00% 3 Missing ⚠️
app/routes/server.$serverId.tags.colors.ts 80.00% 0 Missing and 1 partial ⚠️
app/servers/ServersService.server.ts 0.00% 0 Missing and 1 partial ⚠️
app/tags/TagsService.server.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   58.69%   61.28%   +2.58%     
==========================================
  Files          13       15       +2     
  Lines         569      607      +38     
  Branches       61       60       -1     
==========================================
+ Hits          334      372      +38     
- Misses        174      175       +1     
+ Partials       61       60       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 2d6ffcb into shlinkio:main May 12, 2024
6 checks passed
@acelaya acelaya deleted the feature/dic branch May 12, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dependency injection container
1 participant