Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight expired/disabled short URLs #750

Closed
CodeAlDente opened this issue Nov 25, 2022 · 10 comments · Fixed by #771
Closed

Highlight expired/disabled short URLs #750

CodeAlDente opened this issue Nov 25, 2022 · 10 comments · Fixed by #771
Labels
Milestone

Comments

@CodeAlDente
Copy link

Summary

You can set an expiration date for short URLs. But on the listing page you can't tell which short URL has been expired and which not. I would like to highlight this maybe with an indicator just like there's one if you set a max number of visits. Additionally to this, filter expired short URLs would be a nice thing, too!

@acelaya
Copy link
Member

acelaya commented Nov 25, 2022

Good idea!

The filtering will have to be added to Shlink itself. I'll create a linked ticket there.

@acelaya acelaya added this to the 3.9.0 milestone Nov 25, 2022
@acelaya acelaya added this to Shlink Nov 25, 2022
@acelaya acelaya moved this to Todo 🗒️ in Shlink Dec 16, 2022
@acelaya acelaya moved this from Todo 🗒️ to In Progress 📝 in Shlink Dec 17, 2022
@acelaya
Copy link
Member

acelaya commented Dec 18, 2022

I have explored a couple of ways to highlight "disabled" short URLs, like using italic text, reduced opacity, smaller text size, etc. They all look weird and have side effects (like affecteing the context menu).

The best-looking option so far is this, adding a badge indicating the URL is disabled and why.

I have also added extra information of all limits in the visits field.

disabled.URLs.desktop.mp4

@CodeAlDente
Copy link
Author

Looks good!! 🥰

Why don't you show the reason right in the tooltip of that "disabled" label?

@acelaya
Copy link
Member

acelaya commented Dec 18, 2022

Why don't you show the reason right in the tooltip of that "disabled" label?

That's the plan. This is a conceptual test of the UI that I liked the most so far.

I'm also trying to figure out what's the proper term. Not sure if "disabled" is the right one.

@CodeAlDente
Copy link
Author

I'm also trying to figure out what's the proper term. Not sure if "disabled" is the right one.

Maybe use

  • reached (red)
    • when links have been accessed x times
  • scheduled (yellow/grey)
    • when links are not valid yet (set by "valid after")
  • expired (red)
    • for links where "valid until" date has been reached

Maybe only an icon would fit here? Or use both: text and icon based on the reason why the link has been disabled.

@acelaya
Copy link
Member

acelaya commented Dec 18, 2022

I like the idea of using different icons and colors depending on the status.

The only question is what happens if multiple are met, but I guess it's not that critical.

"Scheduled" would always have lower priority, and we just need to decide about the other two.

Also, with this approach I'm also considering on having the status icon on a separate column, and have a dedicated icon with dedicated color (blue?) for "valid" short URLs (no limits have been reached yet).

I'll try to do another proof of concrete for this.

@acelaya
Copy link
Member

acelaya commented Dec 18, 2022

How does this look:

disabled.URLs.split.desktop.mp4

There is a problem for when the short URLs are "valid". This is the status which most of them are going to have always, and having the screen full of "blue ticks" might be a bit confusing/overwhelming.

Because of this I'm also considering to not displaying an icon at all for those.

I'm also not sure what's the best place to display the icon itself: First column? Next to the short URL? At the end before the button?

I'm also experimenting with the mobile version and where/how to display the status.

@CodeAlDente
Copy link
Author

How does this look:

That is brilliant! It really fits in perfectly to the rest of the UI.

I'm also not sure what's the best place to display the icon itself: First column? Next to the short URL? At the end before the button?

At the end, absolutely yes! Call that column "Status" and we're all set. 😎

There is a problem for when the short URLs are "valid". This is the status which most of them are going to have always, and having the screen full of "blue ticks" might be a bit confusing/overwhelming.

Because of this I'm also consideraing to not display an icon at all for those.

Not at all! Atleast to me. It's good to see that those links are working properly. In fact, I've seen you're planning to check target urls for malicious content? cf. shlinkio/shlink#1305

That status column can then even be used to indicate problems with urls like when they're blacklisted and/or have status code e.g. 404. Then the tick icon can be changed to question or exclamation mark, depending on severity of error/event to raise attention.

@acelaya
Copy link
Member

acelaya commented Dec 18, 2022

Thanks for the feedback!

@acelaya acelaya moved this from In Progress 📝 to In review 👀 in Shlink Dec 19, 2022
Repository owner moved this from In review 👀 to Done ✅ in Shlink Dec 19, 2022
@acelaya
Copy link
Member

acelaya commented Dec 19, 2022

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants