Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow filtering disabled short URLs on the list endpoint #1612

Closed
acelaya opened this issue Nov 25, 2022 · 2 comments · Fixed by #1622
Closed

Allow filtering disabled short URLs on the list endpoint #1612

acelaya opened this issue Nov 25, 2022 · 2 comments · Fixed by #1622
Labels
feature
Milestone
3.4.0

Comments

@acelaya
Copy link
Member

acelaya commented Nov 25, 2022

Summary

Allow to filter-out all short URLs with a "validUntil" in the past.

Refs shlinkio/shlink-web-client#750
@acelaya acelaya added this to the 3.4.0 milestone Nov 25, 2022
@acelaya acelaya added this to Shlink Nov 25, 2022
@CodeAlDente
Copy link

Maybe we should also filter for short URLs where the max number of visits has reached? As they're disabled then as well.

@acelaya
Copy link
Member Author

acelaya commented Nov 25, 2022

I'll probably allow both separately, for flexibility, and then let the front-end decide how to combine them

@acelaya acelaya moved this to Todo 🗒️ in Shlink Dec 3, 2022
@acelaya acelaya moved this from Todo 🗒️ to In Progress 📝 in Shlink Dec 8, 2022
@acelaya acelaya mentioned this issue Dec 9, 2022
Merged
@acelaya acelaya moved this from In Progress 📝 to In review 👀 in Shlink Dec 11, 2022
Repository owner moved this from In review 👀 to Done ✅ in Shlink Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
Shlink
Archived in project
Milestone
3.4.0
Development

Successfully merging a pull request may close this issue.

Feature/filter out disabled acelaya-forks/shlink
2 participants
@acelaya @CodeAlDente