Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly promote installer config as env vars #2208

Closed
acelaya opened this issue Oct 7, 2024 · 0 comments · Fixed by #2211
Closed

Explicitly promote installer config as env vars #2208

acelaya opened this issue Oct 7, 2024 · 0 comments · Fixed by #2211
Milestone

Comments

@acelaya
Copy link
Member

acelaya commented Oct 7, 2024

Right now, installer config is promoted as env vars as if it was a regular config file. This is not entirely correct, as it does not really return any config at all to merge with the rest of the app config, but instead it reads the config, and sets the values as env vars if they are not set yet.

The reason it's done like this is likely because in the past, the installer config was in fact returning an array to merge with the rest of the config.

Right now it makes no sense to do it like that, and instead it should be an explicit step done right before the config is loaded. Issues like #2201 demonstrate it's easy to forget when are those env vars set because they are not explicitly loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant