Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote installer config options as env vars explicitly #2211

Merged

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Oct 8, 2024

#2201 showed that the fact that loading the config also promotes installer options as env vars is something easy to forget.

This PR changes that so that promoting config options is done explicitly, in case any of them needs to be read anywhere outside of config files, reducing the changes of reading the env var too early.

Closes #2208

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.73%. Comparing base (447ccca) to head (15b53ef).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2211   +/-   ##
==========================================
  Coverage      94.73%   94.73%           
  Complexity      1551     1551           
==========================================
  Files            269      269           
  Lines           5200     5200           
==========================================
  Hits            4926     4926           
  Misses           274      274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit a8e4b2f into shlinkio:develop Oct 8, 2024
29 checks passed
@acelaya acelaya deleted the feature/explicit-env-from-config branch October 8, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly promote installer config as env vars
1 participant