Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unix socket connection to MySQL and PostgreSQL #833

Closed
darinpope opened this issue Sep 10, 2020 · 7 comments · Fixed by #925
Closed

Support unix socket connection to MySQL and PostgreSQL #833

darinpope opened this issue Sep 10, 2020 · 7 comments · Fixed by #925
Labels
Milestone

Comments

@darinpope
Copy link

Summary

If you use Google Cloud Run along with Google Cloud SQL, the only option available uses unix sockets when using the currently GA Public IP offerings. Extend the connection configuration to support unix sockets.

Documentation

Note

  • Although you can use the standard connection methods with a Private IP Cloud SQL offering, private IP is still in beta for both Cloud Run and Cloud SQL. By providing unix sockets, that allows us to use the GA offerings.
@acelaya
Copy link
Member

acelaya commented Sep 10, 2020

Sounds like something nice to have.

@acelaya acelaya added this to the 2.4.0 milestone Sep 13, 2020
@acelaya acelaya modified the milestones: 2.4.0, 2.5.0 Oct 16, 2020
@acelaya
Copy link
Member

acelaya commented Nov 29, 2020

Hey @darinpope. The change is almost ready, but I'm having some dificulties to test it.

If I publish a v2.5.0-alpha.1 including this, would you be open to test it on your Google Cloud set-up and confirm if it works?

@darinpope
Copy link
Author

sure, I can try it out. However, it may be a little later in the week before I can work on it.

@acelaya
Copy link
Member

acelaya commented Nov 29, 2020

Sure, that's perfect. I'll try to publish the alpha version during the week and afterwards, you can test it whenever you can/want.

acelaya added a commit to acelaya-forks/shlink that referenced this issue Nov 29, 2020
@acelaya
Copy link
Member

acelaya commented Nov 29, 2020

So basically, this alpha version (and the next stable version if everything goes right) will allow you to provide the DB_UNIX_SOCKET env var to the docker image, in order to define the socket for MySQL, MariaDB or Postgres.

It will also support it during the manual installation if you are not using the docker image, but since you mentioned Google Cloud Run, I guess it's the former for you.

@acelaya
Copy link
Member

acelaya commented Nov 29, 2020

Once this is finished, a docker image for v2.5.0-alpha.1 will be available: https://github.com/shlinkio/shlink/runs/1470673278

@darinpope
Copy link
Author

After a false start, it appears to install and run, but I need to do more validation work in GCP. More to come...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants