-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base URL redirects always use 302? #867
Comments
This shouldn't probably be the case. If you have configured custom redirects for "not found" URLs, they should honor the type of redirects you configured, probably. I'll take a look to see if there's any other consideration, but this looks like a bug to me. |
Hey @codaamok, I have fixed this behavior, so that redirects configured for the base path, not found short URLs and other not-found paths also respect the same status code configured during installation. I even considered hardcoding higher caching times for these three, but I finally used the same logic as for regular short URLs, because it's planned to make shlink track these visits too, at some point. The fix will be released later today/tomorrow with v2.4.1 |
The v2.4.1 has just been released, including the fix for this. |
That's awesome, thank you so much @acelaya |
Maybe I'm seeing things, but am I correct in observing that the redirect options you configure when invoking
./install
are always 302, even if the user configures their short codes to be issued with 301? I have multiple domains responding on my shlink instance and I had to implement nginx rules to return 301 instead of 302 if someone queried$http_host = mydomain.com
and$request_uri = /
.When a user advises Google of a "Change of address" via the Google Search Console, Google is expecting 301 and will not let the user submit the "Change of address" if it is anything else.
The text was updated successfully, but these errors were encountered: