Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on league/plates #912

Closed
acelaya opened this issue Nov 22, 2020 · 0 comments · Fixed by #915
Closed

Remove dependency on league/plates #912

acelaya opened this issue Nov 22, 2020 · 0 comments · Fixed by #915
Labels
tech debt
Milestone
2.5.0

Comments

@acelaya
Copy link
Member

acelaya commented Nov 22, 2020

Shlink is currently using league/plates to render two templates. The problem is that the project seems quite unmaintained, and does not support PHP 8.

Try to replace it with a simple static set of templates to remove one dependency and easy adding support to PHP 8.
@acelaya acelaya added this to the 2.5.0 milestone Nov 22, 2020
@acelaya acelaya mentioned this issue Nov 22, 2020
Closed
28 tasks
acelaya added a commit to acelaya-forks/shlink that referenced this issue Nov 22, 2020
@acelaya
shlinkio#912 Removed dependency on league/plates
49ea5cc
acelaya added a commit to acelaya-forks/shlink that referenced this issue Nov 22, 2020
@acelaya
shlinkio#912 Fixed unit tests
39bda51
acelaya added a commit to acelaya-forks/shlink that referenced this issue Nov 22, 2020
@acelaya
shlinkio#912 Updated changelog
abe0fc1
@acelaya acelaya mentioned this issue Nov 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

Feature/remove plates acelaya-forks/shlink
1 participant
@acelaya