Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve locks #1094

Merged
merged 5 commits into from
May 23, 2021
Merged

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented May 23, 2021

Refs #953

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2021

Codecov Report

Merging #1094 (46bea24) into develop (bf0c679) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1094   +/-   ##
==========================================
  Coverage      97.21%   97.21%           
- Complexity      1059     1063    +4     
==========================================
  Files            170      170           
  Lines           3448     3453    +5     
==========================================
+ Hits            3352     3357    +5     
  Misses            96       96           
Impacted Files Coverage Δ Complexity Δ
module/Core/src/Model/ShortUrlIdentifier.php 100.00% <100.00%> (ø) 9.00 <3.00> (+3.00)
...e/src/Paginator/Adapter/VisitsPaginatorAdapter.php 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
module/Core/src/Repository/ShortUrlRepository.php 100.00% <100.00%> (ø) 36.00 <5.00> (+2.00)
module/Core/src/Repository/VisitRepository.php 100.00% <100.00%> (ø) 25.00 <2.00> (ø)
...dule/Core/src/Service/ShortUrl/ShortCodeHelper.php 100.00% <100.00%> (ø) 4.00 <0.00> (-1.00)
...ule/Core/src/Service/ShortUrl/ShortUrlResolver.php 100.00% <100.00%> (ø) 7.00 <0.00> (ø)
...l/Resolver/PersistenceShortUrlRelationResolver.php 100.00% <100.00%> (ø) 8.00 <0.00> (ø)
module/Core/src/Visit/VisitsStatsHelper.php 100.00% <100.00%> (ø) 9.00 <0.00> (ø)
...Core/src/EventDispatcher/NotifyVisitToWebHooks.php 100.00% <0.00%> (ø) 7.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf0c679...46bea24. Read the comment docs.

@acelaya acelaya merged commit 8ee3bb4 into shlinkio:develop May 23, 2021
@acelaya acelaya deleted the feature/improve-locks branch May 23, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants