Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/deprecate domain env vars #1186

Merged

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Sep 26, 2021

Closes #1164

@codecov-commenter
Copy link

Codecov Report

Merging #1186 (c622654) into develop (dc466f2) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1186      +/-   ##
=============================================
- Coverage      97.11%   97.06%   -0.06%     
  Complexity      1128     1128              
=============================================
  Files            183      183              
  Lines           3574     3574              
=============================================
- Hits            3471     3469       -2     
- Misses           103      105       +2     
Impacted Files Coverage Δ
...Core/src/EventDispatcher/NotifyVisitToWebHooks.php 93.75% <0.00%> (-6.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc466f2...c622654. Read the comment docs.

@acelaya acelaya merged commit ce7296e into shlinkio:develop Sep 26, 2021
@acelaya acelaya deleted the feature/deprecate-domain-env-vars branch September 26, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate SHORT_DOMAIN_* env vars
2 participants