Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/visits threshold change #1284

Merged

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Dec 18, 2021

Closes #1283

@codecov-commenter
Copy link

Codecov Report

Merging #1284 (277d817) into develop (558a4a2) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1284   +/-   ##
==========================================
  Coverage      96.88%   96.88%           
  Complexity      1152     1152           
==========================================
  Files            178      178           
  Lines           3596     3598    +2     
==========================================
+ Hits            3484     3486    +2     
  Misses           112      112           
Impacted Files Coverage Δ
...le/Core/src/Domain/Repository/DomainRepository.php 100.00% <0.00%> (ø)
...ore/src/Service/ShortUrl/DeleteShortUrlService.php 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 558a4a2...277d817. Read the comment docs.

@acelaya acelaya merged commit 5e781a9 into shlinkio:develop Dec 19, 2021
@acelaya acelaya deleted the feature/visits-threshold-change branch December 19, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable "delete threshold" if the DELETE_SHORT_URL_THRESHOLD env var is not provided.
2 participants