Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/visited url always #2070

Merged
merged 4 commits into from
Mar 24, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Mar 24, 2024

Closes #1330

Shlink has been tracking the visited URL for non-orphan visits since this feature was introduced, but the information has never been exposed for that kind of visits.

This PR ensures the visitedUrl is exposed for domain, tag, non-orphan and short URL visits.

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.35%. Comparing base (e028d8e) to head (b4c46ce).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2070   +/-   ##
==========================================
  Coverage      97.35%   97.35%           
- Complexity      1342     1343    +1     
==========================================
  Files            251      250    -1     
  Lines           4765     4772    +7     
==========================================
+ Hits            4639     4646    +7     
  Misses           126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya marked this pull request as ready for review March 24, 2024 16:26
@acelaya acelaya merged commit 207d5ad into shlinkio:develop Mar 24, 2024
23 checks passed
@acelaya acelaya deleted the feature/visited-url-always branch March 24, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include information about visited URL in non-short URL visits
1 participant