Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load non-orphan visits overview via short url visits counts #2081

Merged

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Mar 31, 2024

Part of #2036 and #2080

Make use of the new tracked short URL visits counts when counting non-orphan visits for the visits overview endpoint.

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.30%. Comparing base (90514c6) to head (6e82509).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2081   +/-   ##
==========================================
  Coverage      97.30%   97.30%           
- Complexity      1357     1359    +2     
==========================================
  Files            252      253    +1     
  Lines           4855     4866   +11     
==========================================
+ Hits            4724     4735   +11     
  Misses           131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya force-pushed the feature/performant-count-visits branch from c41f233 to 6e82509 Compare March 31, 2024 11:05
@acelaya acelaya merged commit 401046f into shlinkio:develop Mar 31, 2024
23 checks passed
@acelaya acelaya deleted the feature/performant-count-visits branch March 31, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant