Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to update short URLs #2164

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Jul 25, 2024

Closes #2163

Add a new short-url:edit command to ensure parity between command line and REST API.

Editing short URLs has been supported for quite some time, but the addition of the console command was overlooked.

@acelaya acelaya marked this pull request as ready for review July 26, 2024 17:55
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.99%. Comparing base (ae0ff5f) to head (a1afc90).
Report is 1 commits behind head on develop.

Files Patch % Lines
module/CLI/src/Input/ShortUrlDataInput.php 94.93% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2164   +/-   ##
==========================================
  Coverage      95.98%   95.99%           
- Complexity      1520     1537   +17     
==========================================
  Files            266      268    +2     
  Lines           5137     5189   +52     
==========================================
+ Hits            4931     4981   +50     
- Misses           206      208    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 7f9dc10 into shlinkio:develop Jul 26, 2024
31 checks passed
@acelaya acelaya deleted the feature/update-url-cli branch July 26, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add console command to edit short URLs
1 participant