Properly fail on try verify a seahaven sol when in freecell mode

There are Likely many similar bugs
shlomif · Nov 28, 2024 · ed179b9 · ed179b9
1 parent 6584ee7
commit ed179b9
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 2 deletions.
diff --git a/cpan/Games-Solitaire-Verify/Games-Solitaire-Verify/lib/Games/Solitaire/Verify/Solution.pm b/cpan/Games-Solitaire-Verify/Games-Solitaire-Verify/lib/Games/Solitaire/Verify/Solution.pm
@@ -218,7 +218,14 @@ sub verify
     {
         return { error => $err, line_num => $self->_ln(), };
     }
-    else
+    elsif (
+        $err = Exception::Class->caught(
+            'Games::Solitaire::Verify::Exception::State::MissingCards')
+        )
+    {
+        return { error => $err, line_num => $self->_ln(), };
+    }
+    elsif (1)
     {
         $err = Exception::Class->caught();
         ref $err ? $err->rethrow : die $err;

diff --git a/cpan/Games-Solitaire-Verify/Games-Solitaire-Verify/t/exception-newline.t b/cpan/Games-Solitaire-Verify/Games-Solitaire-Verify/t/exception-newline.t
@@ -14,7 +14,7 @@ if ($@)
 }
 else
 {
-    plan tests => 2;
+    plan tests => 4;
 }
 
 {
@@ -36,3 +36,30 @@ else
     like( $trap->stderr(), qr#\AWrong.*\n\z#, "Trailing newline in error line.",
     );
 }
+
+{
+    my $exit_code;
+    trap(
+        sub {
+            $exit_code = system(
+                $^X, "-I", "lib",
+                "bin/verify-solitaire-solution",
+                "t/data/sample-solutions/fcs-seahaven-towers-1977.txt"
+            );
+        }
+    );
+
+    # TEST
+    ok( $exit_code,
+"[Freecell mode trying to verify Seahaven Towers] Non zero (failure) process exit code."
+    );
+
+    # TEST
+    like(
+        $trap->stderr(),
+
+        # qr#\AWrong.*\n\z#,
+        qr#\S#ms,
+"[Freecell mode trying to verify Seahaven Towers] Trailing newline in error line.",
+    );
+}