Update Packaging configuration and remove ico from binary

shmuelie · Jan 9, 2024 · ea27f53 · ea27f53
1 parent 3d7ab25
commit ea27f53
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -61,7 +61,7 @@
     <Copyright>Copyright (c) 2022 Shmueli Englard</Copyright>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
-    <PackageIcon>icon.png</PackageIcon>
+    <PackageIcon>$(MSBuildProjectName)-128.png</PackageIcon>
     <PackageIconUrl>https://github.com/shmuelie/Shmuelie.WinRTServer/blob/main/Shmuelie.WinRTServer-64.png?raw=true</PackageIconUrl>
     <PackageTags>dotnet net netcore netstandard csharp library windows com winrt oop outofprocess rpc</PackageTags>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>

diff --git a/src/Shmuelie.WinRTServer/Shmuelie.WinRTServer.csproj b/src/Shmuelie.WinRTServer/Shmuelie.WinRTServer.csproj
@@ -3,7 +3,6 @@
     <TargetPlatformVersion>10.0.22000.0</TargetPlatformVersion>
     <TargetPlatformMinVersion>10.0.18362.0</TargetPlatformMinVersion>
     <TargetFrameworks>netstandard2.0;net8.0-windows$(TargetPlatformVersion)</TargetFrameworks>
-    <ApplicationIcon>..\..\$(MSBuildProjectName).ico</ApplicationIcon>
     <IsPackable>true</IsPackable>
     <PackageReleaseNotes>Added support for modern .NET servers.</PackageReleaseNotes>
     <PolySharpIncludeRuntimeSupportedAttributes>true</PolySharpIncludeRuntimeSupportedAttributes>
@@ -21,16 +20,13 @@
     <PackageReference Include="Microsoft.Windows.CsWin32" Version="0.3.49-beta" PrivateAssets="all" IncludeAssets="runtime; build; native; contentfiles; analyzers" />
   </ItemGroup>
   <ItemGroup>
-    <Content Include="$(ApplicationIcon)" Pack="false">
-      <Link>$(MSBuildProjectName).ico</Link>
-    </Content>
-    <Content Include="..\..\$(MSBuildProjectName)-128.png" PackFolder="\">
+    <None Include="..\..\$(MSBuildProjectName)-128.png" PackagePath="\" Pack="true">
       <Link>icon.png</Link>
-    </Content>
-    <None Include="../../README.md" PackFolder="\">
+    </None>
+    <None Include="../../README.md" PackagePath="\" Pack="true">
       <Visible>false</Visible>
     </None>
-    <None Include="../../LICENSE" PackFolder="\">
+    <None Include="../../LICENSE" PackagePath="\" Pack="true">
       <Visible>false</Visible>
     </None>
     <None Include="..\..\.editorconfig" Pack="false">