Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native AOT Compatibility! #29

Merged
merged 43 commits into from
Sep 3, 2024
Merged

Native AOT Compatibility! #29

merged 43 commits into from
Sep 3, 2024

Conversation

shmuelie
Copy link
Owner

shmuelie and others added 14 commits August 16, 2024 08:57
@shmuelie shmuelie added this to the Version 2.0 milestone Aug 27, 2024
This was linked to issues Aug 27, 2024
Use ComWrappers in .NET 6+ #12
Closed
Enable Native AOT Support #21
Closed
@shmuelie shmuelie added the enhancement New feature or request label Aug 28, 2024
@shmuelie shmuelie requested a review from Sergio0694 August 28, 2024 15:25
Sergio0694
Sergio0694 reviewed Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done a first pass, left a few notes

src/Shmuelie.WinRTServer/Windows/Com/IActivationFactory.cs Outdated Show resolved Hide resolved
tests/Shmuelie.WinRTServer.Sample.ServerNet6/Shmuelie.WinRTServer.Sample.ServerNet6.csproj Outdated Show resolved Hide resolved
tests/Shmuelie.WinRTServer.Sample.ServerNet6/Shmuelie.WinRTServer.Sample.ServerNet6.csproj Outdated Show resolved Hide resolved
src/Shmuelie.WinRTServer/Internal/BaseClassFactoryWrapper.cs Outdated Show resolved Hide resolved
src/Shmuelie.WinRTServer/Shmuelie.WinRTServer.csproj Outdated Show resolved Hide resolved
src/Shmuelie.WinRTServer/Shmuelie.WinRTServer.csproj Outdated Show resolved Hide resolved
@shmuelie shmuelie self-assigned this Aug 29, 2024
@shmuelie shmuelie merged commit f1b917e into main Sep 3, 2024
8 checks passed
@shmuelie shmuelie deleted the drop-ns20 branch September 3, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT left review comments

@beervoley beervoley beervoley left review comments

@Sergio0694 Sergio0694 Sergio0694 left review comments

Assignees

@shmuelie shmuelie

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 2.0
Development

Successfully merging this pull request may close these issues.

Enable Native AOT Support Use ComWrappers in .NET 6+
4 participants
@shmuelie @Sergio0694 @beervoley @AaronRobinsonMSFT