Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawing order incorrect in more complex images #1

Closed
alexparlett opened this issue May 7, 2024 · 3 comments
Closed

Drawing order incorrect in more complex images #1

alexparlett opened this issue May 7, 2024 · 3 comments

Comments

@alexparlett
Copy link

alexparlett commented May 7, 2024

Thanks for the library - find it really useful.

Drawing order is not quite correct in a more complex image.

image

Uvall

Blown up the points to illustrate.

                let edges = Edges::from(image);
                let mut bounds = edges.single_image_edge_translated();
@shnewto
Copy link
Owner

shnewto commented May 7, 2024

Oh interesting, yeah I'll take a look 🤔 Thanks for raising the issue! And for including the sprite 🙏 😄

Happy to hear it's been a useful crate for you ❤️

@shnewto
Copy link
Owner

shnewto commented May 12, 2024

wow that was a doozy of a bug, but I think it's tackled now after #2

if you're up for it @alexparlett, I'd love it if you made a pr to add that sprite to the assets directory so it can be used for manual regression checks?

thanks again for raising the issue, your example sprite was perfect for debugging the behavior and looking back on the bug now, it explains some flakiness I've bumped into and wasn't able to pinpoint the cause.

@shnewto
Copy link
Owner

shnewto commented May 12, 2024

oh also, here's the edges drawn after the changes (now publised to crates io)
image

@shnewto shnewto closed this as completed May 12, 2024
shnewto pushed a commit that referenced this issue Nov 11, 2024
Finally, the edge collection algorithm has been rewritten to work with diagonal lines and objects with holes.
shnewto added a commit that referenced this issue Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants