fix sl-rating sometimes not resetting correctly when using `precisi…

…on` and leaving with the mouse (#1877) Co-authored-by: cyantree <cyantree@users.noreply.github.com>
shoelace-style · Feb 20, 2024 · 6440387 · 6440387
1 parent f3be768
commit 6440387
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/components/rating/rating.component.ts b/src/components/rating/rating.component.ts
@@ -264,7 +264,6 @@ export default class SlRating extends ShoelaceElement {
                     'rating__symbol--hover': this.isHovering && Math.ceil(displayValue) === index + 1
                   })}
                   role="presentation"
-                  @mouseenter=${this.handleMouseEnter}
                 >
                   <div
                     style=${styleMap({
@@ -297,7 +296,6 @@ export default class SlRating extends ShoelaceElement {
                   'rating__symbol--active': displayValue >= index + 1
                 })}
                 role="presentation"
-                @mouseenter=${this.handleMouseEnter}
               >
                 ${unsafeHTML(this.getSymbol(index + 1))}
               </span>

diff --git a/src/components/rating/rating.styles.ts b/src/components/rating/rating.styles.ts
@@ -57,6 +57,7 @@ export default css`
 
   .rating__symbol {
     transition: var(--sl-transition-fast) scale;
+    pointer-events: none;
   }
 
   .rating__symbol--hover {