<sl-dialog> await hide() doesn't work in testing environment

[BalusC]

While using of Shoelace 2.17.1 I discovered 2 issues:

1. await hide() doesn't work before a second show()

dialog.show();
// ...
await dialog.hide();
dialog.show();

The second show basically reuses the same dialog component for different content. But it gets hidden immediately basically because the animated hide isn't fully completed at that moment. I'd intuitively expect the await hide() to hook on sl-after-hide. This is therefore open for improvement.

Update: Invalid. It was caused by a mistake on my side. Excuses! But the next issue still remains.

2. await hide() doesn't work in testing environment

The promise simply never resolves. I guess it's related to the headless nature of testing enrivonments. I'm using WTR with Chai/Mocha. This is probably also open for improvement. I've for now replaced it by a "sleep" of 150ms.

[KonnorRogers]

While using of Shoelace 2.17.1 I discovered 2 issues:

1. await hide() doesn't work before a second show()

dialog.show();
// ...
await dialog.hide();
dialog.show();

The second show basically reuses the same dialog component for different content. But it gets hidden immediately basically because the animated hide isn't fully completed at that moment. I'd intuitively expect the await hide() to hook on sl-after-hide. This is therefore open for improvement.

2. await hide() doesn't work in testing environment

The promise simply never resolves. I guess it's related to the headless nature of testing enrivonments. I'm using WTR with Chai/Mocha. This is probably also open for improvement. I've for now replaced it by a "sleep" of 150ms.

I belive show() is also a promise. Could you try:

await dialog.show();
await dialog.hide();
await dialog.show();

[BalusC]

While creating a reproducer I figured out the await hide() before show actually works fine. Excuses!

The second issue still remains though. The await hide() never resolves in a testing environment.

[CetinSert]

Playground with multiple versions:

1. Open sl.rt.ht/2319 → ✔️ 2.19.1 everything works! (Press F12 to confirm!)
2. Press Ctrl + I to focus the input panel.
3. Press ↓ × 2 → ✔️ 2.17.1 everything works! (Press F12 to confirm!)

@BalusC – cannot reproduce the issue!

[BalusC]

The keyword is "testing environment". E.g. WTR/Mocha/Chai.

[KonnorRogers]

The keyword is "testing environment". E.g. WTR/Mocha/Chai.

What testing environment? Do you have a reproduction we could look at?