Move keydown handler for sl-drawer back to base div #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restores the stacking behaviour of drawers See: shoelace-style#1457
|
@grncdr is attempting to deploy a commit to the Font Awesome Team on Vercel. A member of the Team first needs to authorize it. |
|
TODO: if we proceed with this approach, we will need to update |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
claviska
approved these changes
Jul 18, 2023
Whoops, this wasn't a good fix because it only runs the first time the drawer is connected + updated, plus the test was still failing locally for me for some reason. I reverted this one for now. I think there's a way to do what you're trying to as-is, so let me try to whip up a working example before we go any further here. |
circular-semantic-release bot
pushed a commit
to circular-o/circular
that referenced
this pull request
Aug 4, 2023
# [1.7.0-next.1](v1.6.0...v1.7.0-next.1) (2023-08-04) ### Bug Fixes * valueAsDate now falls back to native implementation ([shoelace-style#1399](https://github.com/circular-o/circular/issues/1399)) ([a4f0ae9](a4f0ae9)) ### Features * **details:** use details and summary html tag to enable in browser searching ([shoelace-style#1470](https://github.com/circular-o/circular/issues/1470)) ([89f0f4a](89f0f4a)) * Syncs Shoelace next branch ([3b66b01](3b66b01)) * Syncs Shoelace next branch ([0999b51](0999b51)) * Syncs Shoelace next branch ([5e50390](5e50390)) ### Reverts * Revert "Move keydown handler for sl-drawer back to base div (shoelace-style#1459)" ([f954233](f954233)), closes [shoelace-style#1459](https://github.com/circular-o/circular/issues/1459)
circular-semantic-release bot
pushed a commit
to circular-o/circular
that referenced
this pull request
Aug 4, 2023
# [1.7.0](v1.6.0...v1.7.0) (2023-08-04) ### Bug Fixes * valueAsDate now falls back to native implementation ([shoelace-style#1399](https://github.com/circular-o/circular/issues/1399)) ([a4f0ae9](a4f0ae9)) ### Features * **details:** use details and summary html tag to enable in browser searching ([shoelace-style#1470](https://github.com/circular-o/circular/issues/1470)) ([89f0f4a](89f0f4a)) * Syncs Shoelace next branch ([3b66b01](3b66b01)) * Syncs Shoelace next branch ([0999b51](0999b51)) * Syncs Shoelace next branch ([5e50390](5e50390)) ### Reverts * Revert "Move keydown handler for sl-drawer back to base div (shoelace-style#1459)" ([f954233](f954233)), closes [shoelace-style#1459](https://github.com/circular-o/circular/issues/1459)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the stacking behaviour of drawers.
See discussion from #1457
The first change broke a test case that expects an
<sl-drawer open>can be closed by pressing Escape. Looking back at #925, I've opted to fix this by focusing the drawers panel element if the drawer is open the first time it updates. In the case of drawers that are dynamically opened, the existing code already focuses the drawer panel.