Fixed Firefox select-test #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed failing firefox select-test
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issue: #1915
It appears that in the reset-example the select overlays the button, and therefor the button cannot be pressed with the clickOnElement function (which uses screen coordinates). I verified this behavior using a 200px top-margin on the button, which also solves this behavior. Nevertheless, just calling click() appears a bit cleaner to me.
I further investigated the other failing test (color-picker): "should emit sl-focus when rendered inline and focused" fails regularly.