Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try registering without anonymous classes first #2079

Merged

Conversation

KonnorRogers
Copy link
Collaborator

@KonnorRogers KonnorRogers commented Jun 19, 2024

Fixes issues with Jest / Testing Library snapshots

Fixes #1872

@ct-ofc

Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
shoelace ✅ Ready (Inspect) Visit Preview Jun 21, 2024 5:28pm

@claviska
Copy link
Member

I’m fine with the change, but it could use a comment so we know why it’s there.

@manuelc2209
Copy link
Contributor

@KonnorRogers probably it would be a good idea, this is the type of issue, in a near near future, we tend to do a cleanup and end up thinking this is redundant

I’m fine with the change, but it could use a comment so we know why it’s there.

@KonnorRogers
Copy link
Collaborator Author

I’m fine with the change, but it could use a comment so we know why it’s there.

The comment is there...I just forgot how git works and never pushed it 🙃

will push when I get back in front of the laptop

@KonnorRogers
Copy link
Collaborator Author

Will also add a changelog note as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type Error: Illegal Constructor thrown at runtime when instantiating Shoelace components by constructor
3 participants