Fix carousel newActiveSlide calculation to account for slidesPerPage #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
We always need to scroll to the left most slide of the page. With rtl documents that's the last slide of the page.
claviska
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigating with the arrow key after reaching the last page leads to visual bugs with the pagination. This is because it tries to set newActiveSlide to a value too large if slidesPerPage is larger than 1.
Here is a video:
https://github.com/user-attachments/assets/6a1a7091-9ea7-46aa-ad2f-5ba1eee43536
After the fix:
https://github.com/user-attachments/assets/a59012bd-c4ec-416a-bbfc-d7d11d4a1497
I'm not sure if the change in line 466 is necessary.Edit:
I also added a fix for #1989.