Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gtk 3.20.0 issues #369

Closed
ccoupe opened this issue Sep 7, 2017 · 12 comments
Closed

Gtk 3.20.0 issues #369

ccoupe opened this issue Sep 7, 2017 · 12 comments
Assignees
@ccoupe
Labels
FreeBSD GTK3 Linux Normal Windows
Milestone
3.3.7

Comments

@ccoupe
Copy link

ccoupe commented Sep 7, 2017 •
edited by IanTrudel
Loading

The freebsd port brought some loud an numerous warning messages on stderr. The numerous (overwhelming) GTK warnings started in Gtk 3.20.0 and supposedly there is a patch that some linux/bsd distributions may or may not apply in a timely manner. Gtk 3 actively discourages pixel counting layout like Shoes does in favor of their own container/constraint layout manager scheme. (OSX/Cocoa encourages this too).

You can send them off to .../shoes 2>/dev/null but that defeats to purpose of having a command line. Of course if you start from the Menu, you'll never the warnings.

It does not appear to be something Shoes can fix easily (or ever?). This issue is filed for the future.
@IanTrudel IanTrudel mentioned this issue Sep 17, 2017
Closed
@IanTrudel
Copy link
Collaborator

You might enjoy reading Migrating from GTK+ 2.x to GTK+ 3 manual.

@ccoupe ccoupe added High and removed Low labels Oct 18, 2017
ccoupe pushed a commit that referenced this issue Oct 18, 2017
on #369 establish branch 'subclass'
ef376e6 
* attempt to get GtkLabel to stop whining - used in buttons so
  shoes -c is a simple test case
* work was done on minbsd target - it doesn't stop the whine
  but it's being called.
@ccoupe
Copy link
Author

ccoupe commented Oct 18, 2017 •
edited
Loading

I'm moving this to high priority because Shoes as we know it now, won't be fun for anyone to develop on. Fix it now or give up. One day I'll upgrade to a Linux/Gtk3 that has this problem. I've created a branch of 'master' called 'subclass' .

Update:
The button code in the subclass branch used GtkLabel (an earlier version of widgetfonts branch). Now it reports GtkLabel_Alt in whining. Gdb shows that it is being called for preferred_height and width so there's something else needed. FYI - most of this work is being done on a freebsd VM.

Valuable read.

@ccoupe
Copy link
Author

ccoupe commented Oct 20, 2017

I'm getting a sense of the problem. GtkButton can be (is a container for our purposes). gtkbuttonalt.c doesn't do the needed gtk size protocols for children/containers.

@IanTrudel
Copy link
Collaborator

I'm getting a sense of the problem. GtkButton can be (is a container for our purposes). gtkbuttonalt.c doesn't do the needed gtk size protocols for children/containers.

I did seem obvious when I suggested to removed the custom preferred width/height. It's not doing it right and thus causing warnings.

ccoupe pushed a commit that referenced this issue Oct 24, 2017
for #369 - just saving progress
b89051e
@IanTrudel
Copy link
Collaborator

The GTK code in Shoes would certainly benefit from peer review. I'd like to invite @memnoth to join Shoes3. He is a Gnome programmer from Korea. Perhaps a warm welcome will tempt him to join us... :) :) :)

@ccoupe
Copy link
Author

ccoupe commented May 18, 2018

By all means, @memnoth would be welcome. I can think of ways to add the Gtk Grid layout to Shoes but it's tricky and less Shoes llike than flows and stacks. And we got to figure out the height for width (or vice versa) to get Gtk 3.20 happy. Lots of challenges.

@lsahn-gh
Copy link

It would be great idea to join. By the way, I need to take times to get to know this project. :)

@IanTrudel
Copy link
Collaborator

It would be great idea to join. By the way, I need to take times to get to know this project. :)

So good to have you here @memnoth ! I am willing to help you out with "the getting to know" part. Got the feeling that a fast start will make you unstoppable. :)

ccoupe referenced this issue Jun 10, 2018
fixes gtk3.20+ whines for list_box (aka combobox)
3a3b956 
* remove unwanted previous attempts to fix things
  gtkfixedalt and gtklabelalt
ccoupe referenced this issue Jun 10, 2018
fix gtk 3.20 warnings on button sizing
f228031 
* could backport to 3.3.6 if needed.
@ccoupe ccoupe added Normal and removed High labels Jun 10, 2018
@ccoupe ccoupe added this to the 3.3.7 milestone Jun 10, 2018
@ccoupe ccoupe self-assigned this Jun 10, 2018
ccoupe pushed a commit that referenced this issue Jun 10, 2018
for #369 - edit_box and the undocumented,unfinished textview widget
4d47d7d 
* return proper sizing.
ccoupe pushed a commit that referenced this issue Jun 10, 2018
for #369 - edit_line (gtkentryalt) and sizing
350fbef
@ccoupe
Copy link
Author

ccoupe commented Jul 17, 2018 •
edited
Loading

I'm giving serious consideration to how to get gtk2 back into Shoes. I just ran into a Theme bug on the Raspberry Pi (PiX theme) that shows how unstable gtl3 is - lots of unfinished work to go around. Gtk2 could be a big task but it might be worth it. Thoughts?

@ccoupe
Copy link
Author

ccoupe commented Jul 26, 2018

I also read on the Gtk blog that 3.24 will be the last of the 3 series and from their perspective, they are done breaking things in 3.x and moving onto Gtk 4 (in 2019)

ccoupe pushed a commit that referenced this issue Jul 30, 2018
for #369
3141126 
* fix some gtk3.22 compiler warnings
* fix msys2 and xmsys2 targets. Working again!
* has Ruby 2.3.7, gtk 3.22
* fontconfig issue - runs OK (enough) for now
@ccoupe
Copy link
Author

ccoupe commented Jul 30, 2018

Now that msys2 and xmsys2 targets don't suck, there is another gtk 3.22 target - the latest raspbian. I discovered that newer ubuntu's have arm cross compiler package(s) apt-get install gcc-5-multilib-arm-linux-gnueabihf or use brew on OSX. That needs a set of rake files and dependencies for Shoes but shouldn't be two hard to do.

@ccoupe
Copy link
Author

ccoupe commented Jan 16, 2019

Closing 3.3.7 issues.

@ccoupe ccoupe closed this as completed Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ccoupe ccoupe

Labels
FreeBSD GTK3 Linux Normal Windows
Projects
None yet
Milestone
3.3.7
Development

No branches or pull requests
3 participants
@ccoupe @IanTrudel @lsahn-gh