-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce notes-start-tag option #1141
Conversation
Warning Rate Limit Exceeded@shogo82148 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 33 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent update introduces a new feature for the GitHub CLI, specifically the ability to specify a Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
action.yml
is excluded by:!**/*.yml
Files selected for processing (1)
- README.md (1 hunks)
Additional comments: 1
README.md (1)
- 91-94: The addition of the
notes-start-tag
input option is correctly documented under the Inputs section. Ensure that the description is clear and provides enough information for users to understand its purpose and how to use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (4)
- tests/create.test.ts (4 hunks)
- src/create-release.ts (4 hunks)
- src/create.ts (2 hunks)
- src/github-mini.ts (2 hunks)
Additional comments: 15
src/create.ts (2)
- 24-24: The addition of
notes_start_tag
is consistent with the PR's objective to introduce anotes-start-tag
input option. Ensure that the input is properly validated before use.- 45-45: The
notes_start_tag
parameter is correctly passed to thecreate
function. This change aligns with the new feature implementation.src/create-release.ts (6)
- 2-2: The switch from
fs
tofs/promises
indicates a move to promise-based filesystem operations, which is a modernization of the codebase.- 19-19: The
notes_start_tag
property has been added to theOptions
interface, which is necessary for the new feature to function correctly.- 43-43: The use of
const
fortarget_commitish
is appropriate since it's not reassigned later. This change improves code clarity.- 44-44: Similarly,
discussion_category_name
is now a constant, which is a good practice when the variable is not modified.- 49-49: The variable
generate_release_notes
is set tofalse
by default, which is a change in behavior. Ensure that this change is intentional and documented.- 57-74: The logic for generating release notes has been modified to include the
notes_start_tag
. Ensure that this new logic is thoroughly tested, especially the conditional paths.src/github-mini.ts (3)
- 103-110: New interface
GenerateReleaseNotesParams
is introduced to encapsulate parameters for the release notes generation feature.- 112-115: The
GenerateReleaseNotesResponse
interface is correctly defined to handle the response from the release notes generation.- 198-214: The
generateReleaseNotes
method is added to theClient
class, which is necessary for the new feature to interact with the GitHub API.__tests__/create.test.ts (4)
- 45-45: The
notes_start_tag
parameter is added with a default empty string value in test cases. Ensure that tests are also added to cover non-empty and edge case values.- 128-128: The
notes_start_tag
parameter is correctly included in the test for overwriting an existing release.- 225-225: The
notes_start_tag
parameter is included in the test for overwriting an existing release and tag. Ensure that the behavior whennotes_start_tag
is provided is tested.- 298-298: The addition of
notes_start_tag
in the test for overwriting a non-existing release is consistent with the changes. Ensure that tests cover scenarios where the tag does not exist.
close #918
Summary by CodeRabbit
notes_start_tag
for release note generation.