MySQL 9.0 is released #1085
MySQL 9.0 is released #1085
Conversation
WalkthroughThis update introduces MySQL version 9.0.0 support throughout several build and testing scripts. It refines regex patterns to include 9.x versions, skips unnecessary .pdb files installation for Windows targets, and ensures scripts use the latest clang versions for MacOS. These changes improve the build process, streamline dependencies management, and expand version compatibility. Changes
PoemTipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- patches/mysql/9.0.0/skip-install-pdb.patch (1 hunks)
- versions/mysql.json (1 hunks)
Files skipped from review due to trivial changes (1)
- versions/mysql.json
Additional comments not posted (2)
patches/mysql/9.0.0/skip-install-pdb.patch (2)
70-79: Removal of .pdb file installation logic in add_harness_plugin function.The changes to the
add_harness_pluginfunction to exclude.pdbfile installation are clear and align with the intention to reduce artifact sizes. Ensure this change does not disrupt the router plugin functionalities or any dependent features.Verification successful
No additional logic dependent on old installation behavior found.
The search results indicate that the
add_harness_pluginfunction's usage is only modified within the patch files themselves. There are no other dependencies or logic in the repository that rely on the old installation behavior of.pdbfiles.
patches/mysql/9.0.0/skip-install-pdb.patchpatches/mysql/8.4.0/skip-install-pdb.patchpatches/mysql/8.3.0/skip-install-pdb.patchpatches/mysql/8.2.0/skip-install-pdb.patchpatches/mysql/8.1.0/skip-install-pdb.patchpatches/mysql/8.0.34/skip-install-pdb.patchpatches/mysql/8.0.36/skip-install-pdb.patchpatches/mysql/8.0.37/skip-install-pdb.patchpatches/mysql/8.0.35/skip-install-pdb.patchpatches/mysql/8.0.28/skip-install-pdb.patchpatches/mysql/8.0.32/skip-install-pdb.patchpatches/mysql/8.0.31/skip-install-pdb.patchpatches/mysql/8.0.29/skip-install-pdb.patchpatches/mysql/8.0.33/skip-install-pdb.patchpatches/mysql/8.0.30/skip-install-pdb.patchpatches/mysql/8.0.27/skip-install-pdb.patchpatches/mysql/8.0.26/skip-install-pdb.patchThis confirms that the removal of
.pdbfile installation does not disrupt the router functionalities.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the removal of .pdb file installation in `add_harness_plugin` does not disrupt router functionalities. # Test: Search for usages of `add_harness_plugin` in the repository. Expect: No additional logic dependent on old installation behavior. rg --type cmake 'add_harness_plugin'Length of output: 185
Script:
#!/bin/bash # Description: Verify that the removal of .pdb file installation in `add_harness_plugin` does not disrupt router functionalities. # Test: Search for usages of `add_harness_plugin` in the repository with debug information to understand why files might be skipped. rg --type cmake 'add_harness_plugin' --debugLength of output: 30471
Script:
#!/bin/bash # Description: Verify that the removal of .pdb file installation in `add_harness_plugin` does not disrupt router functionalities. # Test: Search for usages of `add_harness_plugin` in the repository without ignoring any files. rg --type cmake 'add_harness_plugin' --no-ignoreLength of output: 197
Script:
#!/bin/bash # Description: Verify that the removal of .pdb file installation in `add_harness_plugin` does not disrupt router functionalities. # Test: Use `fd` to find all CMake files and then `rg` to search within those files for `add_harness_plugin`. fd -e cmake | xargs rg 'add_harness_plugin'Length of output: 1704
8-38: Changes to INSTALL_DEBUG_SYMBOLS macro are appropriate given the PR objectives.The simplification of the
INSTALL_DEBUG_SYMBOLSmacro to prevent the installation of.pdbfiles aligns with the PR's goal of reducing artifact size for GitHub Actions. However, it's crucial to ensure this doesn't affect other parts of the MySQL build system unexpectedly.Verification successful
No impact on the build system from changes to INSTALL_DEBUG_SYMBOLS macro.
The
INSTALL_DEBUG_SYMBOLSmacro is only referenced within patch files, indicating that the changes to this macro are isolated and do not affect other parts of the build system.
patches/mysql/9.0.0/skip-install-pdb.patchpatches/mysql/8.4.0/skip-install-pdb.patchpatches/mysql/8.3.0/skip-install-pdb.patchpatches/mysql/8.2.0/skip-install-pdb.patchpatches/mysql/8.1.0/skip-install-pdb.patchpatches/mysql/8.0.37/skip-install-pdb.patchpatches/mysql/8.0.36/skip-install-pdb.patchpatches/mysql/8.0.35/skip-install-pdb.patchpatches/mysql/8.0.34/skip-install-pdb.patchpatches/mysql/8.0.33/skip-install-pdb.patchpatches/mysql/8.0.32/skip-install-pdb.patchpatches/mysql/8.0.31/skip-install-pdb.patchpatches/mysql/8.0.30/skip-install-pdb.patchpatches/mysql/8.0.29/skip-install-pdb.patchpatches/mysql/8.0.28/skip-install-pdb.patchpatches/mysql/8.0.27/skip-install-pdb.patchpatches/mysql/8.0.26/skip-install-pdb.patchpatches/mysql/5.7.44/skip-install-pdb.patchpatches/mysql/5.7.43/skip-install-pdb.patchpatches/mysql/5.7.42/skip-install-pdb.patchpatches/mysql/5.7.41/skip-install-pdb.patchpatches/mysql/5.7.40/skip-install-pdb.patchpatches/mysql/5.7.39/skip-install-pdb.patchpatches/mysql/5.7.38/skip-install-pdb.patchpatches/mysql/5.7.37/skip-install-pdb.patchpatches/mysql/5.7.36/skip-install-pdb.patchpatches/mysql/5.7.35/skip-install-pdb.patchpatches/mysql/5.6.51/skip-install-pdb.patchScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that no other part of the build system is adversely affected by the changes to INSTALL_DEBUG_SYMBOLS. # Test: Search for usages of `INSTALL_DEBUG_SYMBOLS` in the repository. Expect: No additional logic dependent on old macro behavior. rg --type cmake 'INSTALL_DEBUG_SYMBOLS'Length of output: 188
Script:
#!/bin/bash # Description: Debug why rg is not finding any files to search. # Test: Run rg with --debug to understand why files are being skipped. rg --debug --type cmake 'INSTALL_DEBUG_SYMBOLS'Length of output: 30477
Script:
#!/bin/bash # Description: Search for usages of `INSTALL_DEBUG_SYMBOLS` in the repository without ignoring any files. # Test: Run rg with the `--no-ignore` flag to ensure all files are searched. rg --no-ignore --type cmake 'INSTALL_DEBUG_SYMBOLS'Length of output: 200
Script:
#!/bin/bash # Description: Search for usages of `INSTALL_DEBUG_SYMBOLS` in the repository without any type filter. # Test: Run rg without the `--type cmake` filter to ensure all files are searched. rg --no-ignore 'INSTALL_DEBUG_SYMBOLS'Length of output: 2323
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/build-mysql-windows.ps1 (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/build-mysql-windows.ps1
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/build-mysql-windows.ps1 (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/build-mysql-windows.ps1
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/build-mysql-windows.ps1 (1 hunks)
- versions/mysql.json (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- .github/build-mysql-windows.ps1
- versions/mysql.json
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- t/ssl.t (1 hunks)
Additional comments not posted (1)
t/ssl.t (1)
13-13: LGTM! Ensure the regex pattern covers all intended versions.The regex pattern update correctly includes MySQL version 9.0 and higher. This ensures that the
--ssl-mode=REQUIREDoption is used for these versions.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .github/build-mysql-darwin-macos14.sh (2 hunks)
- .github/build-mysql-darwin.sh (1 hunks)
- .github/build-mysql-linux.sh (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/build-mysql-darwin.sh
Additional comments not posted (4)
.github/build-mysql-darwin-macos14.sh (3)
27-27: LGTM!The comment about using the latest version of clang is clear and aligns with the following lines.
28-28: LGTM!The command to install llvm@17 using brew is correct and necessary for the following clang and clang++ commands.
44-44: LGTM!The condition update to include MySQL 9.x versions ensures that the appropriate OpenSSL version is used.
.github/build-mysql-linux.sh (1)
92-92: LGTM!The condition update to include MySQL 9.x versions ensures that the appropriate OpenSSL version is used.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/build-mysql-darwin.sh (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/build-mysql-darwin.sh
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/build-mysql-darwin-macos14.sh (1 hunks)
- .github/build-mysql-darwin.sh (2 hunks)
Files skipped from review as they are similar to previous changes (2)
- .github/build-mysql-darwin-macos14.sh
- .github/build-mysql-darwin.sh
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/build-mysql-darwin.sh (2 hunks)
Additional comments not posted (1)
.github/build-mysql-darwin.sh (1)
44-44: LGTM! The condition for selecting OpenSSL version is correctly updated.The regex pattern now correctly matches both MySQL 8.x and 9.x versions.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/build-mysql-darwin.sh (2 hunks)
Additional comments not posted (2)
.github/build-mysql-darwin.sh (2)
27-34: LGTM!The changes ensure that the latest version of LLVM (version 17) is used for the build.
46-46: LGTM!The regex pattern in the conditional statement is updated to include MySQL version 9 in addition to 8, ensuring compatibility with the new version.
Summary by CodeRabbit
New Features
Bug Fixes
Chores