-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MySQL 8.4.1 is released #1087
MySQL 8.4.1 is released #1087
Conversation
WalkthroughThe updates primarily involve version updates and regex pattern enhancements across various scripts for MySQL. The version of MySQL has been incrementally updated from 8.4.0 to 8.4.1. Several build scripts have also been modified to improve version detection and include broader ranges. Additionally, a patch has been added to exclude certain large debug files from installation on Windows. Changes
Sequence Diagram(s)No sequence diagrams generated as the changes were too varied and relatively straightforward, focusing on version updates and improvements in version checking logic. Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- versions/mysql.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- versions/mysql.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- versions/mysql.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- versions/mysql.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/build-mysql-darwin.sh (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/build-mysql-darwin.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- .github/build-mysql-darwin-macos14.sh (1 hunks)
- .github/build-mysql-darwin.sh (2 hunks)
- .github/build-mysql-linux.sh (1 hunks)
- .github/build-mysql-windows.ps1 (2 hunks)
Files skipped from review due to trivial changes (1)
- .github/build-mysql-darwin-macos14.sh
Files skipped from review as they are similar to previous changes (1)
- .github/build-mysql-darwin.sh
Additional comments not posted (2)
.github/build-mysql-linux.sh (1)
92-92
: LGTM!The expanded regex pattern correctly includes MySQL versions 10.0 and above.
.github/build-mysql-windows.ps1 (1)
61-61
: LGTM!The expanded regex pattern correctly includes MySQL versions 10.0 and above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/build-mysql-windows.ps1 (2 hunks)
- patches/mysql/8.4.1/skip-install-pdb.patch (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/build-mysql-windows.ps1
Additional comments not posted (2)
patches/mysql/8.4.1/skip-install-pdb.patch (2)
1-38
: Skipping .pdb file installation for Windows targets.The changes remove the logic for installing
.pdb
files for various target types and add comments indicating that the installation is skipped due to the large size of.pdb
files. This can significantly reduce the installation size but might impact debugging capabilities.Please verify that skipping the installation of
.pdb
files does not negatively impact any debugging processes or workflows.
66-76
: Removing .pdb file installation for plugins.The changes remove the logic for installing
.pdb
files for plugins. This can significantly reduce the installation size but might impact debugging capabilities.Please verify that removing the installation of
.pdb
files for plugins does not negatively impact any debugging processes or workflows.
Summary by CodeRabbit
New Features
Enhancements
Bug Fixes