Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL 8.4.1 is released #1087

Merged
merged 7 commits into from
Jul 6, 2024
Merged

MySQL 8.4.1 is released #1087

merged 7 commits into from
Jul 6, 2024

Conversation

shogo82148
Copy link
Owner

@shogo82148 shogo82148 commented Jul 3, 2024

Summary by CodeRabbit

  • New Features

    • Updated MySQL version support to 8.4.1.
  • Enhancements

    • Improved compatibility checks for MySQL versions 10.0 and above in build scripts.
    • Introduced conditional installation of LLVM for MySQL 8.4 or later versions.
    • Skipped installation of large .pdb files for Windows targets to reduce installation size.
  • Bug Fixes

    • Broadened regex patterns in build scripts to correctly identify a wider range of MySQL versions.

Copy link

coderabbitai bot commented Jul 3, 2024

Walkthrough

The updates primarily involve version updates and regex pattern enhancements across various scripts for MySQL. The version of MySQL has been incrementally updated from 8.4.0 to 8.4.1. Several build scripts have also been modified to improve version detection and include broader ranges. Additionally, a patch has been added to exclude certain large debug files from installation on Windows.

Changes

Files Summary
versions/mysql.json Updated MySQL version from 8.4.0 to 8.4.1.
.github/build-mysql-darwin.sh Added conditional for LLVM installation for MySQL versions 8.4 or later.
.github/build-mysql-darwin-macos14.sh, .github/build-mysql-linux.sh Updated regex pattern for broader MySQL version matching.
.github/build-mysql-windows.ps1 Modified conditions for OpenSSL and Bison setup to handle a broader range of MySQL versions using regex.
patches/mysql/8.4.1/skip-install-pdb.patch Introduced patch to skip installation of .pdb files for Windows targets to reduce size.

Sequence Diagram(s)

No sequence diagrams generated as the changes were too varied and relatively straightforward, focusing on version updates and improvements in version checking logic.

Poem

In the scripts where MySQL grows,
New versions bloom, as regex flows.
LLVM stands by for newer days,
While Windows trims its size in ways.
🐇✨ Debug files skip, installation light,
MySQL builds reach a new height. 🌟


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a210d1b and 0bf0f7d.

Files selected for processing (1)
  • versions/mysql.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • versions/mysql.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0bf0f7d and b7edb1d.

Files selected for processing (1)
  • versions/mysql.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • versions/mysql.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b7edb1d and e7144e7.

Files selected for processing (1)
  • versions/mysql.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • versions/mysql.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e7144e7 and 75d4982.

Files selected for processing (1)
  • .github/build-mysql-darwin.sh (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/build-mysql-darwin.sh

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 75d4982 and 6f50403.

Files selected for processing (4)
  • .github/build-mysql-darwin-macos14.sh (1 hunks)
  • .github/build-mysql-darwin.sh (2 hunks)
  • .github/build-mysql-linux.sh (1 hunks)
  • .github/build-mysql-windows.ps1 (2 hunks)
Files skipped from review due to trivial changes (1)
  • .github/build-mysql-darwin-macos14.sh
Files skipped from review as they are similar to previous changes (1)
  • .github/build-mysql-darwin.sh
Additional comments not posted (2)
.github/build-mysql-linux.sh (1)

92-92: LGTM!

The expanded regex pattern correctly includes MySQL versions 10.0 and above.

.github/build-mysql-windows.ps1 (1)

61-61: LGTM!

The expanded regex pattern correctly includes MySQL versions 10.0 and above.

.github/build-mysql-windows.ps1 Outdated Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6f50403 and c03cebf.

Files selected for processing (2)
  • .github/build-mysql-windows.ps1 (2 hunks)
  • patches/mysql/8.4.1/skip-install-pdb.patch (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/build-mysql-windows.ps1
Additional comments not posted (2)
patches/mysql/8.4.1/skip-install-pdb.patch (2)

1-38: Skipping .pdb file installation for Windows targets.

The changes remove the logic for installing .pdb files for various target types and add comments indicating that the installation is skipped due to the large size of .pdb files. This can significantly reduce the installation size but might impact debugging capabilities.

Please verify that skipping the installation of .pdb files does not negatively impact any debugging processes or workflows.


66-76: Removing .pdb file installation for plugins.

The changes remove the logic for installing .pdb files for plugins. This can significantly reduce the installation size but might impact debugging capabilities.

Please verify that removing the installation of .pdb files for plugins does not negatively impact any debugging processes or workflows.

@shogo82148 shogo82148 merged commit 0900f20 into main Jul 6, 2024
248 checks passed
@shogo82148 shogo82148 deleted the mysql-8.4.1-is-released branch July 6, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant