Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable WITH_AUTHENTICATION_CLIENT_PLUGINS #1092

Merged
merged 4 commits into from
Jul 11, 2024
Merged

enable WITH_AUTHENTICATION_CLIENT_PLUGINS #1092

merged 4 commits into from
Jul 11, 2024

Conversation

shogo82148
Copy link
Owner

@shogo82148 shogo82148 commented Jul 10, 2024 •
edited by coderabbitai bot
Loading

It may fix #1089

Summary by CodeRabbit

  • Chores
    • Updated build scripts for macOS, Linux, and Windows to conditionally set CMake options based on MySQL version.
    • Improved handling of authentication plugins and unit tests configurations for different MySQL versions.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 10, 2024 •
edited
Loading

Walkthrough

The scripts for building MySQL on different platforms (Darwin, Linux, and Windows) have been updated to include conditional CMake options based on MySQL version. This ensures compatibility and proper configuration for authentication plugins and unit tests, addressing issues like backward compatibility with older MySQL servers.

Changes

Files Change Summary
.github/build-mysql-darwin.sh Updated CMake options based on MySQL version, including authentication plugins and unit tests configurations.
.github/build-mysql-linux.sh Similar updates to .github/build-mysql-darwin.sh for Linux builds, adjusting CMake options based on MySQL version.
.github/build-mysql-windows.ps1 Conditional logic added to handle different MySQL versions in the CMake command, specific to version 8.0 and later.

Sequence Diagram(s)

No sequence diagrams are necessary for these changes as they mainly involve configuration adjustments without altering the control flow significantly.

Assessment against linked issues

Objective Addressed Explanation
mysqlclient 9.0 not able to load mysql_native_password.so (#1089) ✅

Poem

In scripts of yore, with codes so pure,
MySQL builds evolved, solutions sure.
Authentication plugins align,
With CMake options fine,
Backward compatibility, a win to ensure!

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jul 10, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 14f81b3 and ec7ce51.

Files selected for processing (3)
  • .github/build-mysql-darwin.sh (1 hunks)
  • .github/build-mysql-linux.sh (1 hunks)
  • .github/build-mysql-windows.ps1 (1 hunks)
Additional context used
Learnings (1)
.github/build-mysql-windows.ps1 (1)
Learnt from: shogo82148
PR: shogo82148/actions-setup-mysql#1087
File: .github/build-mysql-windows.ps1:0-0
Timestamp: 2024-07-06T11:40:05.856Z
Learning: The regex pattern in `.github/build-mysql-windows.ps1` for MySQL version matching was corrected to remove an extra `^` character.
Additional comments not posted (9)
.github/build-mysql-darwin.sh (3)

142-148: Conditional CMake options for MySQL 9.0 or later look good.

The added CMake options -DWITH_AUTHENTICATION_CLIENT_PLUGINS=1 and the removal of Boost-related options are appropriate for MySQL 9.0 or later.

150-154: CMake options for MySQL 8.0 look good.

The CMake options for MySQL 8.0 are appropriately set without the WITH_AUTHENTICATION_CLIENT_PLUGINS as it is not required for this version.

156-162: Conditional CMake options for versions other than MySQL 8.0 or later look good.

The CMake options for versions other than MySQL 8.0 or later retain the Boost-related options and remove unnecessary authentication client plugins.

.github/build-mysql-linux.sh (3)

186-192: Conditional CMake options for MySQL 9.0 or later look good.

The added CMake options -DWITH_AUTHENTICATION_CLIENT_PLUGINS=1 and the removal of Boost-related options are appropriate for MySQL 9.0 or later.

194-198: CMake options for MySQL 8.0 look good.

The CMake options for MySQL 8.0 are appropriately set without the WITH_AUTHENTICATION_CLIENT_PLUGINS as it is not required for this version.

200-206: Conditional CMake options for versions other than MySQL 8.0 or later look good.

The CMake options for versions other than MySQL 8.0 or later retain the Boost-related options and remove unnecessary authentication client plugins.

.github/build-mysql-windows.ps1 (3)

169-177: Conditional CMake options for MySQL 9.0 or later look good.

The added CMake options -DWITH_AUTHENTICATION_CLIENT_PLUGINS=1 and the removal of Boost-related options are appropriate for MySQL 9.0 or later.

179-187: CMake options for MySQL 8.0 look good.

The CMake options for MySQL 8.0 are appropriately set without the WITH_AUTHENTICATION_CLIENT_PLUGINS as it is not required for this version.

189-197: Conditional CMake options for versions other than MySQL 8.0 or later look good.

The CMake options for versions other than MySQL 8.0 or later retain the Boost-related options and remove unnecessary authentication client plugins.

coderabbitai[bot]
coderabbitai bot reviewed Jul 10, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ec7ce51 and 152d004.

Files selected for processing (3)
  • .github/build-mysql-darwin.sh (1 hunks)
  • .github/build-mysql-linux.sh (1 hunks)
  • .github/build-mysql-windows.ps1 (1 hunks)
Files skipped from review as they are similar to previous changes (3)
  • .github/build-mysql-darwin.sh
  • .github/build-mysql-linux.sh
  • .github/build-mysql-windows.ps1

coderabbitai[bot]
coderabbitai bot reviewed Jul 10, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 152d004 and 78abc5e.

Files selected for processing (1)
  • .github/build-mysql-windows.ps1 (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/build-mysql-windows.ps1

@shogo82148 shogo82148 merged commit 87e78c9 into main Jul 11, 2024
60 of 248 checks passed
@shogo82148 shogo82148 deleted the with-authentication-client-plugin branch July 11, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mysqlclient 9.0 not able to load mysql_native_password.so
1 participant
@shogo82148