Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cross-compilation for scala 2.13.x and scala-js 1.x, fixed #38 #39

Conversation

viktor-podzigun
Copy link
Contributor

Fixes #38

Notes:

  • some tests were adjusted because of newer scalatest version

TODOs, after dependent PR is merged:

  • update statictags version
  • un-comment scala 2.13 and scalajs 1.x in .travis.yml

@viktor-podzigun viktor-podzigun force-pushed the fix_38_add_cross_compilation branch 4 times, most recently from c92e931 to 0008a82 Compare February 10, 2021 09:52
@shogowada
Copy link
Owner

Thank you for the contribution!

Unfortunately, I cannot maintain this project anymore. If you could inherit this project, that'd be hugely appreciated 🙏 https://github.com/shogowada/scalajs-reactjs/blob/master/README.md

@viktor-podzigun
Copy link
Contributor Author

hi @shogowada,
thanks of offering of maintenance of the repo. I would be happy to inherit it and further maintain it, please, see the PR #40

@viktor-podzigun
Copy link
Contributor Author

Close in favor of scommons PR#1

@viktor-podzigun viktor-podzigun deleted the fix_38_add_cross_compilation branch February 11, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cross-compilation for scala 2.13.x and scala-js 1.x
2 participants