Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] shopinvader: make the base_pricelist and base_pricelist.currency_id fields defined in the tests usable globally #897

Merged

Conversation

chafique-delli
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #897 (4bf9559) into 14.0 (5e95b5f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             14.0     #897      +/-   ##
==========================================
- Coverage   91.40%   91.39%   -0.01%     
==========================================
  Files          78       78              
  Lines        4745     4743       -2     
==========================================
- Hits         4337     4335       -2     
  Misses        408      408              
Impacted Files Coverage Δ
shopinvader/tests/common.py 94.30% <100.00%> (ø)
shopinvader/tests/test_product.py 98.53% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e95b5f...4bf9559. Read the comment docs.

…urrency_id fields defined in the tests usable globally
@chafique-delli chafique-delli force-pushed the 14.0-fix-shopinvader_tests branch from 4bf9559 to 8f4b6b2 Compare February 25, 2021 10:19
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

/ocabot merge patch

@shopinvader-git-bot
Copy link

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-897-by-rousseldenis-bump-patch, awaiting test results.

@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at a90771e. Thanks a lot for contributing to shopinvader. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants