-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SFCORE-2829: Allow to use SDK Order operation with id or reference/channelName #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR, it seems almost OK for me.
Please take care to ensure the backward compatibility for anyone using this code. It means any change of existing public methods should be done in a compatible way. You can check this document when you are not sure : https://symfony.com/doc/current/contributing/code/bc.html
…dd trigger deprecation
Co-authored-by: Dumoulin <martin@shopping-feed.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a last BC break issue on class constants. Sorry, I did not spot it before. I think we are good after that. Thanks for the work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Aurelieluciani
Link to the Ticket
https://shopping-feed.atlassian.net/browse/SFCORE-2829
What does the PR do
We want to add the possibility to call the operation 'deliver' from SDK, but with id instead of reference/channelName (wich is deprecated).
How to test
On master
Operation types allowed: accept, cancel, ship, refuse, acknowledge, unacknowledge, uploadDocument, refund
On branch
or
Operation types allowed: accept, cancel, ship, refuse, acknowledge, unacknowledge, uploadDocument, refund, deliver