Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFCORE-2829: Allow to use SDK Order operation with id or reference/channelName #119

Merged
merged 22 commits into from
Jul 22, 2024

Conversation

Aurelieluciani
Copy link
Contributor

@Aurelieluciani Aurelieluciani commented Jul 15, 2024

Link to the Ticket

https://shopping-feed.atlassian.net/browse/SFCORE-2829

What does the PR do

We want to add the possibility to call the operation 'deliver' from SDK, but with id instead of reference/channelName (wich is deprecated).

How to test

On master

$operation = new \ShoppingFeed\Sdk\Api\Order\OrderOperation();
$operation->refuse('ref1', 'amazon');
$orderApi->execute($operation);

Operation types allowed: accept, cancel, ship, refuse, acknowledge, unacknowledge, uploadDocument, refund

On branch

$operation = new \ShoppingFeed\Sdk\Api\Order\Operation();
$operation->refuse(new Id(1234));
$orderApi->execute($operation);

or

(deprecated)
$operation = new \ShoppingFeed\Sdk\Api\Order\OrderOperation();
$operation->refuse('ref1', 'amazon');
$orderApi->execute($operation);

Operation types allowed: accept, cancel, ship, refuse, acknowledge, unacknowledge, uploadDocument, refund, deliver

@Aurelieluciani Aurelieluciani added the enhancement New feature or request label Jul 15, 2024
@Aurelieluciani Aurelieluciani self-assigned this Jul 15, 2024
@Aurelieluciani Aurelieluciani requested a review from a team July 15, 2024 15:32
Copy link
Contributor

@mdumoulin mdumoulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR, it seems almost OK for me.

Please take care to ensure the backward compatibility for anyone using this code. It means any change of existing public methods should be done in a compatible way. You can check this document when you are not sure : https://symfony.com/doc/current/contributing/code/bc.html

src/Api/Order/OrderOperation.php Show resolved Hide resolved
src/Api/Order/OrderOperation.php Outdated Show resolved Hide resolved
src/Api/Order/Operation.php Outdated Show resolved Hide resolved
src/Api/Order/Identifier/OrderIdentifier.php Show resolved Hide resolved
@Aurelieluciani Aurelieluciani requested a review from mdumoulin July 17, 2024 10:34
Co-authored-by: Dumoulin <martin@shopping-feed.com>
@Aurelieluciani Aurelieluciani requested a review from mdumoulin July 18, 2024 13:46
Copy link
Contributor

@mdumoulin mdumoulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a last BC break issue on class constants. Sorry, I did not spot it before. I think we are good after that. Thanks for the work.

@Aurelieluciani Aurelieluciani requested a review from mdumoulin July 22, 2024 07:47
Copy link
Contributor

@mdumoulin mdumoulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdumoulin mdumoulin merged commit 8adad8e into master Jul 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants