feature: added possibility to have a proxied webhook url #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstegmeyer
reviewed
Jul 23, 2024
Comment on lines
+11
to
+12
| paypal: | ||
| webhook_proxy_url: null |
There was a problem hiding this comment.
could you do one more layer? so
paypal:
webhook:
proxy_url: null
Background: we will in a future iteration, add more config parameters to the yaml files, therefore we would like to have some sort of namespacing
Comment on lines
+109
to
+120
| if ($this->proxyWebhookUrl !== null) { | ||
| $webhookUrl = $this->proxyWebhookUrl . '?' . http_build_query( | ||
| [self::PAYPAL_WEBHOOK_TOKEN_NAME => $webhookExecuteToken] | ||
| ); | ||
| } else { | ||
| $this->router->getContext()->setScheme('https'); | ||
| $webhookUrl = $this->router->generate( | ||
| 'api.action.paypal.webhook.execute', | ||
| [self::PAYPAL_WEBHOOK_TOKEN_NAME => $webhookExecuteToken], | ||
| UrlGeneratorInterface::ABSOLUTE_URL | ||
| ); | ||
| } |
There was a problem hiding this comment.
Could you please outsource this into an extra private method? So we don't have the duplicate code?
| UrlGeneratorInterface::ABSOLUTE_URL | ||
| ); | ||
| if ($this->proxyWebhookUrl !== null) { | ||
| $webhookUrl = $this->proxyWebhookUrl . '?' . http_build_query( |
There was a problem hiding this comment.
What if the proxy already contains GET parameters? Maybe do a str_contains('?') ? '&' : '?' (overly simplified)
|
@jhony1104 any updates here? are you going to implement the suggested changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this pr is a structure where shopware is not accessible from the internet. Only required endpoints are to be routed to shopware (
/store-api/, WebHooks, ...) using a proxy.This PR is to make this possible for SwagPayPal.