Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extension overrides, fixes #28 #29

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Conversation

shyim
Copy link
Member

@shyim shyim commented Nov 11, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (182df6f) to head (5753c9c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #29   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        32    +1     
  Lines          589       648   +59     
=========================================
+ Hits           589       648   +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitelg mitelg self-requested a review November 12, 2024 08:08
@shyim shyim force-pushed the add-extension-overrides branch 2 times, most recently from 7853a10 to 81415d7 Compare November 12, 2024 08:22
src/Config/ProjectExtensionManagement.php Outdated Show resolved Hide resolved
class ProjectExtensionManagement
{
public const LIFECYCLE_STATE_INACTIVE = 'inactive';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enum? 🤔

src/Services/PluginHelper.php Outdated Show resolved Hide resolved
@shyim shyim merged commit fdeab1e into main Nov 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants