Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): allowlisting #1654

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat(docs): allowlisting #1654

wants to merge 19 commits into from

Conversation

mdanilowicz
Copy link
Collaborator

Description

Type of change

ToDo's

Screenshots (if applicable)

Additional context

@vercel Vercel
Copy link

vercel bot commented Jan 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo 🔄 Building (Inspect) Visit Preview Feb 14, 2025 10:04am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Feb 14, 2025 10:04am

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 28, 2025 •
edited
Loading

Open in Stackblitz

@shopware/api-client

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-client@1654

@shopware/composables

npm i https://pkg.pr.new/shopware/frontends/@shopware/composables@1654

@shopware/helpers

npm i https://pkg.pr.new/shopware/frontends/@shopware/helpers@1654

@shopware/nuxt-module

npm i https://pkg.pr.new/shopware/frontends/@shopware/nuxt-module@1654

@shopware/cms-base-layer

npm i https://pkg.pr.new/shopware/frontends/@shopware/cms-base-layer@1654

@shopware/api-gen

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-gen@1654

commit: a94f1fc

@mdanilowicz mdanilowicz changed the title feat: preview test feat(docs): whitelisting Feb 4, 2025
@mdanilowicz mdanilowicz marked this pull request as ready for review February 4, 2025 07:47
@patzick patzick changed the title feat(docs): whitelisting feat(docs): allowlisting Feb 4, 2025
patzick
patzick requested changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • let's use automd to have tested code examples
  • let's change whitelist for allowlist

.changeset/twenty-papayas-drive.md Outdated Show resolved Hide resolved
apps/docs/src/getting-started/features/maintenance-mode.md Outdated Show resolved Hide resolved
apps/docs/src/getting-started/features/maintenance-mode.md Outdated Show resolved Hide resolved
apps/docs/src/getting-started/features/maintenance-mode.md Outdated Show resolved Hide resolved
apps/docs/src/getting-started/features/maintenance-mode.md Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – shopware-frontends-docs February 9, 2025 20:58 Inactive
patzick
patzick requested changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better but the example is not building. Looks like logo.svg is missing

examples/maintenance-allowlisting/package.json Outdated Show resolved Hide resolved
examples/maintenance-allowlisting/package.json Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – shopware-frontends-docs February 12, 2025 10:36 Inactive
@mdanilowicz mdanilowicz requested a review from patzick February 12, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrocksiNet BrocksiNet BrocksiNet left review comments

@mkucmus mkucmus mkucmus approved these changes

@patzick patzick Awaiting requested review from patzick

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdanilowicz @BrocksiNet @mkucmus @patzick