Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(e2e): test with different workflows #332

Closed
wants to merge 21 commits into from

Conversation

BrocksiNet
Copy link
Collaborator

Description

Use one workflow as a trigger and only run e2e when the other workflow is completed. Pass target_url via cache.

Type of change

Improvement for e2e execution only on demo-store.

Additional context

grafik

@vercel
Copy link

vercel bot commented Jul 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview Aug 7, 2023 7:54am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Aug 7, 2023 7:54am

@BrocksiNet BrocksiNet changed the title Feat/different workflows for e2e feat(e2e): test with different workflows Jul 20, 2023
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see trigger is fired, but e2e-tests is not in checks

@BrocksiNet
Copy link
Collaborator Author

This always shows the last run of a workflow:
image

So if the workflow is executed twice the easiest solution is to set a wait timer in environments (image is from another example repo):
image

If we set the wait timer for the demo store deployment and the demo store is then always the last workflow that runs ... the display should be fine.

@BrocksiNet BrocksiNet closed this Sep 5, 2023
@patzick patzick deleted the feat/different-workflows-for-e2e branch September 5, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants