Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to doctrine/dbal 4.0 - deprecations for updated functionality #6282

Merged
merged 11 commits into from
Jan 28, 2025

Conversation

h1k3r
Copy link
Contributor

@h1k3r h1k3r commented Jan 16, 2025

1. Why is this change necessary?

This PR contains deprecations related to doctrine/dbal update in the next major #5861

2. What does this change do, exactly?

All deprecated functionality is marked in phpdoc and using Feature::triggerDeprecationOrThrow where possible.

3. Please link to the relevant issues (if any).

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 50.20%. Comparing base (c247cea) to head (17e370d).
Report is 1 commits behind head on trunk.

Files with missing lines Patch % Lines
...k/DataAbstractionLayer/Dbal/Common/LastIdQuery.php 0.00% 2 Missing ⚠️
...k/DataAbstractionLayer/Dbal/Common/OffsetQuery.php 0.00% 2 Missing ⚠️
.../Core/Checkout/Cart/Command/CartMigrateCommand.php 0.00% 1 Missing ⚠️
...AbstractionLayer/DataAbstractionLayerException.php 0.00% 1 Missing ⚠️
...taAbstractionLayer/Dbal/Common/IteratorFactory.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk    #6282      +/-   ##
==========================================
- Coverage   50.20%   50.20%   -0.01%     
==========================================
  Files        4801     4801              
  Lines      163957   163961       +4     
  Branches     9175     9175              
==========================================
- Hits        82320    82316       -4     
- Misses      78858    78866       +8     
  Partials     2779     2779              
Flag Coverage Δ
jest-admin 59.25% <ø> (ø)
jest-storefront 67.28% <ø> (ø)
phpunit-migration 38.45% <ø> (ø)
phpunit-unit 41.86% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h1k3r h1k3r self-assigned this Jan 16, 2025
@h1k3r h1k3r marked this pull request as ready for review January 16, 2025 16:30
@h1k3r h1k3r requested a review from a team as a code owner January 16, 2025 16:30
@h1k3r h1k3r requested review from keulinho and mitelg January 16, 2025 16:30
@h1k3r h1k3r requested a review from mitelg January 17, 2025 08:24
@h1k3r h1k3r requested a review from AydinHassan January 17, 2025 09:20
@h1k3r h1k3r requested a review from keulinho January 23, 2025 13:20
h1k3r added 2 commits January 27, 2025 17:19
…cations

# Conflicts:
#	src/Core/Framework/Test/TestCaseBase/DatabaseTransactionBehaviour.php
@h1k3r h1k3r merged commit ec26526 into trunk Jan 28, 2025
48 of 49 checks passed
@h1k3r h1k3r deleted the next-39353/dbal-4-0-update-deprecations branch January 28, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants