forked from flutter/flutter
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shorebird_ci #53
Merged
Merged
Fix shorebird_ci #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzanardo
approved these changes
May 22, 2024
What about just "fetch-tags" instead of fetch-depth: 0? |
Or do we specifically need branches? |
I tried with |
Thanks for trying! |
bryanoltman
added a commit
that referenced
this pull request
May 24, 2024
* set fetch depth * fetch tags instead of changing fetch depth * revert to setting fetch-depth to 0 * add comment
bryanoltman
added a commit
that referenced
this pull request
May 28, 2024
* set fetch depth * fetch tags instead of changing fetch depth * revert to setting fetch-depth to 0 * add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the checkout action to fetch all branches and tags, which is required to determine Flutter version.
Note: regular CI still seems to be broken for an unrelated reason.
The problem we're seeing is in https://github.com/shorebirdtech/flutter/actions/runs/9196867990/job/25295975746, where our tests fail with the following:
I'm able to reproduce this by following the same steps as the checkout action.
Proof of fix: https://github.com/shorebirdtech/flutter/actions/runs/9197333224