Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shorebird_ci #53

Merged
merged 4 commits into from
May 22, 2024
Merged

Fix shorebird_ci #53

merged 4 commits into from
May 22, 2024

Conversation

bryanoltman
Copy link

@bryanoltman bryanoltman commented May 22, 2024

Updates the checkout action to fetch all branches and tags, which is required to determine Flutter version.

Note: regular CI still seems to be broken for an unrelated reason.

The problem we're seeing is in https://github.com/shorebirdtech/flutter/actions/runs/9196867990/job/25295975746, where our tests fail with the following:

Exception: Failed to create Flutter project: Downloading Linux x64 Dart SDK from Flutter engine 9f5711d6916088b4caf07badb1aef01b600eff3c...
  Building flutter tool...
  Flutter assets will be downloaded from https://download.shorebird.dev./ Make sure you trust this source!
  Note: leak_tracker_flutter_testing is pinned to version 3.0.3 by flutter_test from the flutter SDK.
  See https://dart.dev/go/sdk-version-pinning for details.
  
  The current Flutter SDK version is 0.0.0-unknown.
  
  Because every version of flutter_test from sdk depends on leak_tracker_flutter_testing >=2.0.3 which requires Flutter SDK version >=3.[18](https://github.com/shorebirdtech/flutter/actions/runs/9196867990/job/25295975746#step:5:19).0-18.0.pre.54, flutter_test from sdk is forbidden.
  So, because shorebird_test depends on flutter_test from sdk, version solving failed.
  
  
  You can try the following suggestion to make the pubspec resolve:
  * Try using the Flutter SDK version: 3.22.0. 
  
  test/shorebird_tests.dart 47:5  _createFlutterProject
  ===== asynchronous gap ===========================
  test/shorebird_tests.dart 75:9  testWithShorebirdProject.<fn>

I'm able to reproduce this by following the same steps as the checkout action.

Proof of fix: https://github.com/shorebirdtech/flutter/actions/runs/9197333224

@bryanoltman bryanoltman marked this pull request as draft May 22, 2024 19:28
@bryanoltman bryanoltman marked this pull request as ready for review May 22, 2024 19:37
@bryanoltman bryanoltman merged commit e96fdb8 into shorebird/dev May 22, 2024
1 of 4 checks passed
@bryanoltman bryanoltman deleted the bo/fix-ci branch May 22, 2024 19:42
@eseidel
Copy link

eseidel commented May 22, 2024

What about just "fetch-tags" instead of fetch-depth: 0?

@eseidel
Copy link

eseidel commented May 22, 2024

Or do we specifically need branches?

@eseidel
Copy link

eseidel commented May 22, 2024

@bryanoltman
Copy link
Author

I tried with fetch-tags and that didn't seem to change the version detection issue ¯_(ツ)_/¯

@eseidel
Copy link

eseidel commented May 22, 2024

Thanks for trying!

bryanoltman added a commit that referenced this pull request May 24, 2024
* set fetch depth

* fetch tags instead of changing fetch depth

* revert to setting fetch-depth to 0

* add comment
bryanoltman added a commit that referenced this pull request May 28, 2024
* set fetch depth

* fetch tags instead of changing fetch depth

* revert to setting fetch-depth to 0

* add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants